Skip to content

Comments

clash-verge-rev: 2.1.2 -> 2.2.2#391733

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
Bot-wxt1221:clash-verge
Mar 29, 2025
Merged

clash-verge-rev: 2.1.2 -> 2.2.2#391733
GaetanLepage merged 1 commit intoNixOS:masterfrom
Bot-wxt1221:clash-verge

Conversation

@Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Mar 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft March 21, 2025 04:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 21, 2025
@nix-owners nix-owners bot requested a review from Guanran928 March 21, 2025 04:36
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review March 21, 2025 10:15
@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft March 21, 2025 10:51
Copy link
Contributor

@HHR2020 HHR2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux.

@Bot-wxt1221
Copy link
Member Author

That actually not work properly. Now upstream eat the tag so they are really ****.

@Bot-wxt1221 Bot-wxt1221 changed the title clash-verge-rev: 2.1.2 -> 2.2.0 clash-verge-rev: 2.1.2 -> 2.2.2 Mar 25, 2025
@Bot-wxt1221 Bot-wxt1221 requested a review from HHR2020 March 25, 2025 10:32
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review March 25, 2025 10:32
Copy link
Contributor

@HHR2020 HHR2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on x86_64-linux, runs properly so far

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 25, 2025
@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft March 28, 2025 12:25
@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Mar 28, 2025

I find it fail to display when service enabled.

UPD: Fixed and testing.

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Mar 28, 2025

We can revert the changes in nixos module because it work with user permission again.

UPD: In the next release.

@Bot-wxt1221 Bot-wxt1221 removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 28, 2025
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review March 28, 2025 13:22
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391733

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/14129993074


x86_64-linux

✅ 1 package built:
  • clash-verge-rev

aarch64-linux

✅ 1 package built:
  • clash-verge-rev

@Bot-wxt1221
Copy link
Member Author

It is hard to compile webkitgtk however you can see that the only diff is the patch's name.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391733


x86_64-linux

✅ 1 package built:
  • clash-verge-rev

aarch64-linux

✅ 1 package built:
  • clash-verge-rev

@Bot-wxt1221 Bot-wxt1221 added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 29, 2025
@GaetanLepage GaetanLepage merged commit 7f7d008 into NixOS:master Mar 29, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants