Skip to content

Comments

pygame-sdl2: 8.3.5.25022704 -> 8.3.7.25031702; renpy: 8.3.6.25022803 -> 8.3.7.25031702#391742

Merged
7c6f434c merged 2 commits intoNixOS:masterfrom
KSJ2000:renpygame-sdl2
Mar 22, 2025
Merged

pygame-sdl2: 8.3.5.25022704 -> 8.3.7.25031702; renpy: 8.3.6.25022803 -> 8.3.7.25031702#391742
7c6f434c merged 2 commits intoNixOS:masterfrom
KSJ2000:renpygame-sdl2

Conversation

@KSJ2000
Copy link
Contributor

@KSJ2000 KSJ2000 commented Mar 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 21, 2025
@nix-owners nix-owners bot requested review from 7c6f434c and ShadowRZ March 21, 2025 06:35
@KSJ2000 KSJ2000 marked this pull request as draft March 21, 2025 06:52
@KSJ2000
Copy link
Contributor Author

KSJ2000 commented Mar 21, 2025

It doesn't like python3Full anymore?
It has weird failures of other packages such as:

execnet
python3.12-execnet> ==================================== ERRORS ====================================
python3.12-execnet> _ ERROR at setup of TestMultiChannelAndGateway.test_multichannel_container_basics[thread-socket] _
python3.12-execnet> request = <SubRequest 'gw' for <Function test_multichannel_container_basics[thread-socket]>>
python3.12-execnet> execmodel = <ExecModel 'thread'>, group = <Group ['popen', 'sproxy1']>
python3.12-execnet>     @pytest.fixture
python3.12-execnet>     def gw(
python3.12-execnet>         request: pytest.FixtureRequest,
python3.12-execnet>         execmodel: ExecModel,
python3.12-execnet>         group: execnet.Group,
python3.12-execnet>     ) -> Gateway:
python3.12-execnet>         try:
python3.12-execnet> >           return group[request.param]
python3.12-execnet> testing/conftest.py:151:
python3.12-execnet> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
python3.12-execnet> self = <Group ['popen', 'sproxy1']>, key = 'socket'
python3.12-execnet>     def __getitem__(self, key: int | str | Gateway) -> Gateway:
python3.12-execnet>         if isinstance(key, int):
python3.12-execnet>             return self._gateways[key]
python3.12-execnet>         for gw in self._gateways:
python3.12-execnet>             if gw == key or gw.id == key:
python3.12-execnet>                 return gw
python3.12-execnet> >       raise KeyError(key)
python3.12-execnet> E       KeyError: 'socket'
python3.12-execnet> /nix/store/wlj74qyhp67plskwp0pv0v0b2g90rg6v-python3.12-execnet-2.1.1/lib/python3.12/site-packages/execnet/multi.py:102: KeyError
python3.12-execnet> During handling of the above exception, another exception occurred:
python3.12-execnet> request = <SubRequest 'gw' for <Function test_multichannel_container_basics[thread-socket]>>
python3.12-execnet> execmodel = <ExecModel 'thread'>, group = <Group ['popen', 'sproxy1']>
python3.12-execnet>     @pytest.fixture
python3.12-execnet>     def gw(
python3.12-execnet>         request: pytest.FixtureRequest,
python3.12-execnet>         execmodel: ExecModel,
python3.12-execnet>         group: execnet.Group,
python3.12-execnet>     ) -> Gateway:
python3.12-execnet>         try:
python3.12-execnet>             return group[request.param]
python3.12-execnet>         except KeyError:
python3.12-execnet>             if request.param == "popen":
python3.12-execnet>                 gw = group.makegateway("popen//id=popen//execmodel=%s" % execmodel.backend)
python3.12-execnet>             elif request.param == "socket":
python3.12-execnet>                 # if execmodel.backend != "thread":
python3.12-execnet>                 #    pytest.xfail(
python3.12-execnet>                 #        "cannot set remote non-thread execmodel for sockets")
python3.12-execnet>                 pname = "sproxy1"
python3.12-execnet>                 if pname not in group:
python3.12-execnet>                     proxygw = group.makegateway("popen//id=%s" % pname)
python3.12-execnet>                 # assert group['proxygw'].remote_status().receiving
python3.12-execnet> >               gw = group.makegateway(
python3.12-execnet>                     f"socket//id=socket//installvia={pname}"
python3.12-execnet>                     f"//execmodel={execmodel.backend}"
python3.12-execnet>                 )
python3.12-execnet> testing/conftest.py:163:
python3.12-execnet> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
python3.12-execnet> /nix/store/wlj74qyhp67plskwp0pv0v0b2g90rg6v-python3.12-execnet-2.1.1/lib/python3.12/site-packages/execnet/multi.py:158: in makegateway
python3.12-execnet>     sio = gateway_socket.create_io(spec, self, execmodel=self.execmodel)
python3.12-execnet> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
python3.12-execnet> spec = <XSpec 'socket//id=socket//installvia=sproxy1//execmodel=thread'>
python3.12-execnet> group = <Group ['popen', 'sproxy1']>, execmodel = <ExecModel 'thread'>
python3.12-execnet>     def create_io(spec: XSpec, group: Group, execmodel: ExecModel) -> SocketIO:
python3.12-execnet>         assert spec.socket is not None
python3.12-execnet>         assert not spec.python, "socket: specifying python executables not yet supported"
python3.12-execnet>         gateway_id = spec.installvia
python3.12-execnet>         if gateway_id:
python3.12-execnet>             host, port = start_via(group[gateway_id])
python3.12-execnet>         else:
python3.12-execnet>             host, port_str = spec.socket.split(":")
python3.12-execnet>             port = int(port_str)
python3.12-execnet>         socket = execmodel.socket
python3.12-execnet>         sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
python3.12-execnet>         io = SocketIO(sock, execmodel)
python3.12-execnet>         io.remoteaddress = "%s:%d" % (host, port)
python3.12-execnet>         try:
python3.12-execnet> >           sock.connect((host, port))
python3.12-execnet> E           PermissionError: [Errno 1] Operation not permitted
python3.12-execnet> /nix/store/wlj74qyhp67plskwp0pv0v0b2g90rg6v-python3.12-execnet-2.1.1/lib/python3.12/site-packages/execnet/gateway_socket.py:99: PermissionError
python3.12-execnet> _ ERROR at setup of TestMultiChannelAndGateway.test_multichannel_container_basics[main_thread_only-socket] _
python3.12-execnet> request = <SubRequest 'gw' for <Function test_multichannel_container_basics[main_thread_only-socket]>>
python3.12-execnet> execmodel = <ExecModel 'main_thread_only'>
python3.12-execnet> group = <Group ['popen', 'sproxy1', 'proxy-transport', 'proxy', 'socket']>
python3.12-execnet>     @pytest.fixture
python3.12-execnet>     def gw(
python3.12-execnet>         request: pytest.FixtureRequest,
python3.12-execnet>         execmodel: ExecModel,
python3.12-execnet>         group: execnet.Group,
python3.12-execnet>     ) -> Gateway:
python3.12-execnet>         try:
python3.12-execnet> >           return group[request.param]
python3.12-execnet> testing/conftest.py:151:
python3.12-execnet> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
python3.12-execnet> self = <Group ['popen', 'sproxy1', 'proxy-transport', 'proxy', 'socket']>
python3.12-execnet> key = 'socket'
python3.12-execnet>     def __getitem__(self, key: int | str | Gateway) -> Gateway:
python3.12-execnet>         if isinstance(key, int):
python3.12-execnet>             return self._gateways[key]
python3.12-execnet>         for gw in self._gateways:
python3.12-execnet>             if gw == key or gw.id == key:
python3.12-execnet>                 return gw
python3.12-execnet> >       raise KeyError(key)
python3.12-execnet> E       KeyError: 'socket'
python3.12-execnet> /nix/store/wlj74qyhp67plskwp0pv0v0b2g90rg6v-python3.12-execnet-2.1.1/lib/python3.12/site-packages/execnet/multi.py:102: KeyError
python3.12-execnet> During handling of the above exception, another exception occurred:
python3.12-execnet> request = <SubRequest 'gw' for <Function test_multichannel_container_basics[main_thread_only-socket]>>
python3.12-execnet> execmodel = <ExecModel 'main_thread_only'>
python3.12-execnet> group = <Group ['popen', 'sproxy1', 'proxy-transport', 'proxy', 'socket']>
python3.12-execnet>     @pytest.fixture
python3.12-execnet>     def gw(
python3.12-execnet>         request: pytest.FixtureRequest,
python3.12-execnet>         execmodel: ExecModel,
python3.12-execnet>         group: execnet.Group,
python3.12-execnet>     ) -> Gateway:
python3.12-execnet>         try:
python3.12-execnet>             return group[request.param]
python3.12-execnet>         except KeyError:
python3.12-execnet>             if request.param == "popen":
python3.12-execnet>                 gw = group.makegateway("popen//id=popen//execmodel=%s" % execmodel.backend)
python3.12-execnet>             elif request.param == "socket":
python3.12-execnet>                 # if execmodel.backend != "thread":
python3.12-execnet>                 #    pytest.xfail(
python3.12-execnet>                 #        "cannot set remote non-thread execmodel for sockets")
python3.12-execnet>                 pname = "sproxy1"
python3.12-execnet>                 if pname not in group:
python3.12-execnet>                     proxygw = group.makegateway("popen//id=%s" % pname)
python3.12-execnet>                 # assert group['proxygw'].remote_status().receiving
python3.12-execnet>                 gw = group.makegateway(
python3.12-execnet>                     f"socket//id=socket//installvia={pname}"
python3.12-execnet>                     f"//execmodel={execmodel.backend}"
python3.12-execnet>                 )
python3.12-execnet>                 # TODO(typing): Clarify this assignment.
python3.12-execnet> >               gw.proxygw = proxygw  # type: ignore[attr-defined]
python3.12-execnet> E               UnboundLocalError: cannot access local variable 'proxygw' where it is not associated with a value
python3.12-execnet> testing/conftest.py:168: UnboundLocalError
python3.12-execnet> =============================== warnings summary ===============================
python3.12-execnet> ../../../../nix/store/ivab6j6npky0qrqpc8gdp49alpzs2d3k-python3.12-pytest-8.3.4/lib/python3.12/site-packages/_pytest/config/__init__.py:1441
python3.12-execnet>   /nix/store/ivab6j6npky0qrqpc8gdp49alpzs2d3k-python3.12-pytest-8.3.4/lib/python3.12/site-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: timeout
python3.12-execnet>     self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
xdist
python3.12-pytest-xdist> =================================== FAILURES ===================================
python3.12-pytest-xdist> _____________ TestNodeFailure.test_max_worker_restart_tests_queued _____________
python3.12-pytest-xdist> [gw3] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12
python3.12-pytest-xdist> self = <acceptance_test.TestNodeFailure object at 0xfffff4b0f950>
python3.12-pytest-xdist> pytester = <Pytester PosixPath('/build/pytest-of-nixbld/pytest-0/popen-gw3/test_max_worker_restart_tests_queued0')>
python3.12-pytest-xdist>     def test_max_worker_restart_tests_queued(self, pytester: pytest.Pytester) -> None:
python3.12-pytest-xdist>         f = pytester.makepyfile(
python3.12-pytest-xdist>             """
python3.12-pytest-xdist>             import os, pytest
python3.12-pytest-xdist>             @pytest.mark.parametrize('i', range(10))
python3.12-pytest-xdist>             def test(i): os._exit(1)
python3.12-pytest-xdist>         """
python3.12-pytest-xdist>         )
python3.12-pytest-xdist>         res = pytester.runpytest(f, "-n2", "--max-worker-restart=3")
python3.12-pytest-xdist> >       res.stdout.fnmatch_lines(
python3.12-pytest-xdist>             [
python3.12-pytest-xdist>                 "replacing crashed worker*",
python3.12-pytest-xdist>                 "maximum crashed workers reached: 3*",
python3.12-pytest-xdist>                 "worker*crashed while running*",
python3.12-pytest-xdist>                 "worker*crashed while running*",
python3.12-pytest-xdist>                 "* xdist: maximum crashed workers reached: 3 *",
python3.12-pytest-xdist>                 "* 4 failed in *",
python3.12-pytest-xdist>             ]
python3.12-pytest-xdist>         )
python3.12-pytest-xdist> E       Failed: nomatch: 'replacing crashed worker*'
python3.12-pytest-xdist> E           and: '============================= test session starts =============================='
python3.12-pytest-xdist> E           and: 'platform linux -- Python 3.12.9, pytest-8.3.4, pluggy-1.5.0'
python3.12-pytest-xdist> E           and: 'rootdir: /build/pytest-of-nixbld/pytest-0/popen-gw3/test_max_worker_restart_tests_queued0'
python3.12-pytest-xdist> E           and: 'plugins: xdist-3.6.1'
python3.12-pytest-xdist> E           and: 'created: 2/2 workers'
python3.12-pytest-xdist> E           and: '2 workers [10 items]'
python3.12-pytest-xdist> E           and: ''
python3.12-pytest-xdist> E           and: '[gw1] node down: Not properly terminated'
python3.12-pytest-xdist> E           and: 'F'
python3.12-pytest-xdist> E       fnmatch: 'replacing crashed worker*'
python3.12-pytest-xdist> E          with: 'replacing crashed worker gw1'
python3.12-pytest-xdist> E       nomatch: 'maximum crashed workers reached: 3*'
python3.12-pytest-xdist> E           and: '[gw0] node down: Not properly terminated'
python3.12-pytest-xdist> E           and: 'F'
python3.12-pytest-xdist> E           and: 'replacing crashed worker gw0'
python3.12-pytest-xdist> E           and: '[gw2] node down: Not properly terminated'
python3.12-pytest-xdist> E           and: 'F'
python3.12-pytest-xdist> E           and: 'replacing crashed worker gw2'
python3.12-pytest-xdist> E           and: '[gw4] node down: Not properly terminated'
python3.12-pytest-xdist> E           and: 'F'
python3.12-pytest-xdist> E       fnmatch: 'maximum crashed workers reached: 3*'
python3.12-pytest-xdist> E          with: 'maximum crashed workers reached: 3'
python3.12-pytest-xdist> E       nomatch: 'worker*crashed while running*'
python3.12-pytest-xdist> E           and: '[gw3] node down: Not properly terminated'
python3.12-pytest-xdist> E           and: 'F'
python3.12-pytest-xdist> E           and: 'maximum crashed workers reached: 3'
python3.12-pytest-xdist> E           and: '                                                                         [ 50%]'
python3.12-pytest-xdist> E           and: '=================================== FAILURES ==================================='
python3.12-pytest-xdist> E           and: '___________________ test_max_worker_restart_tests_queued.py ____________________'
python3.12-pytest-xdist> E           and: '[gw1] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12'
python3.12-pytest-xdist> E       fnmatch: 'worker*crashed while running*'
python3.12-pytest-xdist> E          with: "worker 'gw1' crashed while running 'test_max_worker_restart_tests_queued.py::test[2]'"
python3.12-pytest-xdist> E       nomatch: 'worker*crashed while running*'
python3.12-pytest-xdist> E           and: '___________________ test_max_worker_restart_tests_queued.py ____________________'
python3.12-pytest-xdist> E           and: '[gw0] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12'
python3.12-pytest-xdist> E       fnmatch: 'worker*crashed while running*'
python3.12-pytest-xdist> E          with: "worker 'gw0' crashed while running 'test_max_worker_restart_tests_queued.py::test[0]'"
python3.12-pytest-xdist> E       nomatch: '* xdist: maximum crashed workers reached: 3 *'
python3.12-pytest-xdist> E           and: '___________________ test_max_worker_restart_tests_queued.py ____________________'
python3.12-pytest-xdist> E           and: '[gw2] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12'
python3.12-pytest-xdist> E           and: "worker 'gw2' crashed while running 'test_max_worker_restart_tests_queued.py::test[4]'"
python3.12-pytest-xdist> E           and: '___________________ test_max_worker_restart_tests_queued.py ____________________'
python3.12-pytest-xdist> E           and: '[gw4] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12'
python3.12-pytest-xdist> E           and: "worker 'gw4' crashed while running 'test_max_worker_restart_tests_queued.py::test[3]'"
python3.12-pytest-xdist> E           and: '___________________ test_max_worker_restart_tests_queued.py ____________________'
python3.12-pytest-xdist> E           and: '[gw3] linux -- Python 3.12.9 /nix/store/bzdqkdyfj397606mal63mlk0s15p4xqf-python3-3.12.9/bin/python3.12'
python3.12-pytest-xdist> E           and: "worker 'gw3' crashed while running 'test_max_worker_restart_tests_queued.py::test[8]'"
python3.12-pytest-xdist> E       fnmatch: '* xdist: maximum crashed workers reached: 3 *'
python3.12-pytest-xdist> E          with: '================== xdist: maximum crashed workers reached: 3 ==================='
python3.12-pytest-xdist> E       nomatch: '* 4 failed in *'
python3.12-pytest-xdist> E           and: '=========================== short test summary info ============================'
python3.12-pytest-xdist> E           and: 'FAILED test_max_worker_restart_tests_queued.py::test[2]'
python3.12-pytest-xdist> E           and: 'FAILED test_max_worker_restart_tests_queued.py::test[0]'
python3.12-pytest-xdist> E           and: 'FAILED test_max_worker_restart_tests_queued.py::test[4]'
python3.12-pytest-xdist> E           and: 'FAILED test_max_worker_restart_tests_queued.py::test[3]'
python3.12-pytest-xdist> E           and: 'FAILED test_max_worker_restart_tests_queued.py::test[8]'
python3.12-pytest-xdist> E           and: '============================== 5 failed in 1.27s ==============================='
python3.12-pytest-xdist> E       remains unmatched: '* 4 failed in *'
python3.12-pytest-xdist> /build/pytest_xdist-3.6.1/testing/acceptance_test.py:1007: Failed
python3.12-pytest-xdist> ----------------------------- Captured stdout call -----------------------------
python3.12-pytest-xdist> ============================= test session starts ==============================
python3.12-pytest-xdist> platform linux -- Python 3.12.9, pytest-8.3.4, pluggy-1.5.0
python3.12-pytest-xdist> rootdir: /build/pytest-of-nixbld/pytest-0/popen-gw3/test_max_worker_restart_tests_queued0
python3.12-pytest-xdist> plugins: xdist-3.6.1
python3.12-pytest-xdist> created: 2/2 workers
python3.12-pytest-xdist> 2 workers [10 items]
python3.12-pytest-xdist> [gw1] node down: Not properly terminated
python3.12-pytest-xdist> F
python3.12-pytest-xdist> replacing crashed worker gw1
python3.12-pytest-xdist> [gw0] node down: Not properly terminated
python3.12-pytest-xdist> F
python3.12-pytest-xdist> replacing crashed worker gw0
python3.12-pytest-xdist> [gw2] node down: Not properly terminated
python3.12-pytest-xdist> F
python3.12-pytest-xdist> replacing crashed worker gw2
python3.12-pytest-xdist> [gw4] node down: Not properly terminated
python3.12-pytest-xdist> F
python3.12-pytest-xdist> maximum crashed workers reached: 3

@KSJ2000 KSJ2000 marked this pull request as ready for review March 21, 2025 07:53
@KSJ2000
Copy link
Contributor Author

KSJ2000 commented Mar 21, 2025

Changing to python3 simple did the trick.
This should probably be closed as well, but it got updated to a newer version since the last PR got opened and until it got merged (8.3.7.25031702).
Should probably update this PR to the lastest version as well before merging.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391742

Logs: https://github.com/KSJ2000/nixpkgs-review-gha/actions/runs/13986534843


x86_64-linux

✅ 6 packages built:
  • katawa-shoujo-re-engineered
  • python312Packages.pygame-sdl2
  • python312Packages.pygame-sdl2.dist
  • python313Packages.pygame-sdl2
  • python313Packages.pygame-sdl2.dist
  • renpy

aarch64-linux

✅ 6 packages built:
  • katawa-shoujo-re-engineered
  • python312Packages.pygame-sdl2
  • python312Packages.pygame-sdl2.dist
  • python313Packages.pygame-sdl2
  • python313Packages.pygame-sdl2.dist
  • renpy

x86_64-darwin

✅ 6 packages built:
  • katawa-shoujo-re-engineered
  • python312Packages.pygame-sdl2
  • python312Packages.pygame-sdl2.dist
  • python313Packages.pygame-sdl2
  • python313Packages.pygame-sdl2.dist
  • renpy

aarch64-darwin

✅ 6 packages built:
  • katawa-shoujo-re-engineered
  • python312Packages.pygame-sdl2
  • python312Packages.pygame-sdl2.dist
  • python313Packages.pygame-sdl2
  • python313Packages.pygame-sdl2.dist
  • renpy

image

@7c6f434c 7c6f434c merged commit fa5b633 into NixOS:master Mar 22, 2025
39 checks passed
@KSJ2000 KSJ2000 deleted the renpygame-sdl2 branch March 24, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants