gradle: add test for toolchain functionality#391822
Merged
Ma27 merged 1 commit intoNixOS:masterfrom Mar 28, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: java
The test asserts for the output of the javaToolchains tasks making sure Gradle detected toolchains via environment variables created by the Nix package. Since we can't call override on finalAttrs.finalPackage, the test has to be implemented in wrapGradle instead of in the passthru of the gen function body.
britter
force-pushed
the
britter/gradle/toolchains-test
branch
from
152cff1 to
205f826
Compare
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test asserts for the output of the javaToolchains tasks making sure Gradle detected toolchains via environment variables created by the Nix package.
Since we can't call
overrideonfinalAttrs.finalPackage, the test has to be implemented in wrapGradle instead of in the passthru of the gen function body.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.