ebusd: update to 24.1 and add new log facility option ("device")#391842
ebusd: update to 24.1 and add new log facility option ("device")#391842happysalada merged 2 commits intoNixOS:masterfrom
Conversation
99a507c to
788a554
Compare
788a554 to
329fdc5
Compare
|
@nathan-gs do you have a way I can use for testing this from a github PR/patch? Other than that it's ready to go for instance, this gives me errors with nix-shell, short of duplicating the whole lambda I think: nix-shell -E '
let
pkgs = import <nixpkgs> {};
lib = pkgs.lib;
stdenv = pkgs.stdenv;
ebusd = import (pkgs.fetchurl {
url = "https://raw.githubusercontent.com/NixOS/nixpkgs/91f58b6bb0a235331afd831e10f34e9e9fc542a5/pkgs/by-name/eb/ebusd/package.nix";
sha256 = "sha256-Pbg8+qfJ6suqTguEoipCgb6HwqeXFTuUxs2sSmh25DI="; #pkgs.lib.fakeSha256;
}) { inherit pkgs lib stdenv; };
in
pkgs.mkShell {
buildInputs = [ ebusd ];
}
' |
|
for me it fails on the patch (copy & pasted the code into my local repo), unfortunately without the patch it fails the build with: |
|
The patch should be: Then it builds and ebusd works for me |
|
Sweet - so with that patch (same as the existing one, this PR just drops the gcc patch), then I think we're ok. I haven't been able to build ebusd on my nix machine to test it - is this what you execute? nix-shell -E '
let
pkgs = import <nixpkgs> {};
lib = pkgs.lib;
stdenv = pkgs.stdenv;
fetchFromGitHub = pkgs.fetchFromGitHub;
fetchpatch = pkgs.fetchpatch;
argparse = pkgs.python3Packages.argparse;
mosquitto = pkgs.mosquitto;
cmake = pkgs.cmake;
autoconf = pkgs.autoconf;
automake = pkgs.automake;
libtool = pkgs.libtool;
pkg-config = pkgs.pkg-config;
openssl = pkgs.openssl;
ebusd = import ./ebusd.nix {
inherit lib stdenv pkgs fetchFromGitHub fetchpatch argparse mosquitto cmake autoconf automake libtool pkg-config openssl;
};
in
ebusd
'as I receive an error about argparse ( |
|
the patch is slightly different. I tested it by manually copying the changes to my local nix-conf (a bit cheating) |
|
nathan-gs/nix-conf@3aad271 is more or less how I got it working. |
|
Thanks - that helped, got ebusd 24.1 running, tested with the new |
|
@bobrippling can fix the patch? That one breaks on my side |
91f58b6 to
cf8f830
Compare
|
Sure, how's that? |
|
@nathan-gs @wegank @happysalada could one of you review #380997 please? It changes the default configpath because the current one is set to stop working at some time soon. |
|
Thx @bobrippling for the contrib! |
|
My pleasure, thanks for the review and guidance! |
This updates ebusd to 24.1 - changelog available upstream, config changes now include the
"device"log level.🗒️ Will be away for a few days - wanted to get this ready, will test basic functionality on my return
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.