Skip to content

Comments

OWNERS: add owners for ZFS NixOS module#391863

Merged
adamcstephens merged 1 commit intoNixOS:masterfrom
amarshall:zfs-owners
Mar 21, 2025
Merged

OWNERS: add owners for ZFS NixOS module#391863
adamcstephens merged 1 commit intoNixOS:masterfrom
amarshall:zfs-owners

Conversation

@amarshall
Copy link
Member

Missing change from 46a13b4. Realized this when backporting and 24.11-release has the old owners.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Mar 21, 2025
@nix-owners nix-owners bot requested review from infinisil and philiptaron March 21, 2025 13:22
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 21, 2025
@amarshall amarshall requested a review from adamcstephens March 21, 2025 13:31
@adamcstephens adamcstephens merged commit a9292d1 into NixOS:master Mar 21, 2025
23 of 27 checks passed
@amarshall amarshall deleted the zfs-owners branch March 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants