ghc: Use --hash-unit-ids when supported#391889
Conversation
|
Why is this not the default behavior of hadrian? (Given that it's not documented it's not very discoverable…) Would there be any reason to turn this off? |
|
@sternenseemann It is going to become the default, you should also enable it when distributing. I think it has been opt-in until now just-in-case there were any unforeseen issues with the change to using hashes. See MR: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13444 |
|
@mpickering Then I'd actually lean towards making this unconditional and now adding an |
9687b8e to
00866ff
Compare
|
@sternenseemann Now that https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13444 has landed, hash-unit-ids will be the default when you use the I updated the patch to always enable it for supported versions. Can you take it from here? |
The compilers produced by nixpkgs don't use the detailed ABI hash.
("Project Unit Id","ghc-9.10.1-inplace")
which should rather be
("Project Unit Id","ghc-9.10.1-<HASH>"))
This flag is supported on ghc-9.8 and upwards.
From 9.14, this behaviour will be enabled by default.
https://gitlab.haskell.org/ghc/ghc/-/merge_requests/13444
Co-authored-by: sternenseemann <sternenseemann@systemli.org>
00866ff to
46ebf1b
Compare
The compilers produced by nixpkgs don't use the detailed ABI hash.
("Project Unit Id","ghc-9.10.1-inplace")
which should rather be
("Project Unit Id","ghc-9.10.1-"))
This flag is supported on ghc-9.8 and upwards.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.