Skip to content

Comments

python3Packages.rio-stac: init at 0.10.1#392056

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
daspk04:add-rio-stac
Mar 26, 2025
Merged

python3Packages.rio-stac: init at 0.10.1#392056
GaetanLepage merged 1 commit intoNixOS:masterfrom
daspk04:add-rio-stac

Conversation

@daspk04
Copy link
Contributor

@daspk04 daspk04 commented Mar 22, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 22, 2025
@nix-owners nix-owners bot requested a review from natsukium March 22, 2025 10:23
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this even do anything? This is a library not a program...

Copy link
Contributor Author

@daspk04 daspk04 Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethancedwards8 !

I think I missed to add a mainProgram. Technically this can also be used as a cli. c.f, c.f

However it seems like when I build it, it doesn't generate any file inside bin folder. Ideally this should be there.

Anyways I will remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2025
@daspk04 daspk04 requested a review from GaetanLepage March 25, 2025 16:20
@GaetanLepage
Copy link
Contributor

It is indeed a CLI, so you should add meta.mainProgram and versionCheckHook if possible.

Also, add a pkgs/by-name/ri/rio-stac/package.nix containing:

{ python3Packages }: with python3Packages; toPythonApplication rio-stac

@GaetanLepage
Copy link
Contributor

(merge conflict too)

@daspk04
Copy link
Contributor Author

daspk04 commented Mar 25, 2025

It is indeed a CLI, so you should add meta.mainProgram and versionCheckHook if possible.

Also, add a pkgs/by-name/ri/rio-stac/package.nix containing:

{ python3Packages }: with python3Packages; toPythonApplication rio-stac

Thanks @GaetanLepage !

But the when I built this locally, I found no bin folder being generated. So I'm actually not sure what is the issue. So I didn't add it. earlier comment

@GaetanLepage
Copy link
Contributor

It is indeed a CLI, so you should add meta.mainProgram and versionCheckHook if possible.
Also, add a pkgs/by-name/ri/rio-stac/package.nix containing:

{ python3Packages }: with python3Packages; toPythonApplication rio-stac

Thanks @GaetanLepage !

But the when I built this locally, I found no bin folder being generated. So I'm actually not sure what is the issue. So I didn't add it. earlier comment

Maybe it's a packaging issue on their end then... It's fine to package only the library for now. But it would be better to at least open an issue upstream.

@daspk04 daspk04 force-pushed the add-rio-stac branch 2 times, most recently from 6dd261d to 51b1b0a Compare March 25, 2025 18:57
@GaetanLepage
Copy link
Contributor

If you's not willing to open an issue, maybe simply leave a comment in the file stating that it should provide a program but that nothing is installed in $out/bin.

@daspk04
Copy link
Contributor Author

daspk04 commented Mar 26, 2025

Maybe it's a packaging issue on their end then... It's fine to package only the library for now. But it would be better to at least open an issue upstream.

Thanks @GaetanLepage !

I have added a comment in the file. For now I'm not opening an issue upstream.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392056


x86_64-linux

✅ 4 packages built:
  • python312Packages.rio-stac
  • python312Packages.rio-stac.dist
  • python313Packages.rio-stac
  • python313Packages.rio-stac.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.rio-stac
  • python312Packages.rio-stac.dist
  • python313Packages.rio-stac
  • python313Packages.rio-stac.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.rio-stac
  • python312Packages.rio-stac.dist
  • python313Packages.rio-stac
  • python313Packages.rio-stac.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.rio-stac
  • python312Packages.rio-stac.dist
  • python313Packages.rio-stac
  • python313Packages.rio-stac.dist

@GaetanLepage GaetanLepage merged commit 5bad4ad into NixOS:master Mar 26, 2025
24 of 27 checks passed
@daspk04 daspk04 deleted the add-rio-stac branch March 28, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants