python3Packages.rio-stac: init at 0.10.1#392056
Conversation
There was a problem hiding this comment.
does this even do anything? This is a library not a program...
There was a problem hiding this comment.
Thanks @ethancedwards8 !
I think I missed to add a mainProgram. Technically this can also be used as a cli. c.f, c.f
However it seems like when I build it, it doesn't generate any file inside bin folder. Ideally this should be there.
Anyways I will remove it.
|
It is indeed a CLI, so you should add Also, add a { python3Packages }: with python3Packages; toPythonApplication rio-stac |
|
(merge conflict too) |
Thanks @GaetanLepage ! But the when I built this locally, I found no |
Maybe it's a packaging issue on their end then... It's fine to package only the library for now. But it would be better to at least open an issue upstream. |
6dd261d to
51b1b0a
Compare
|
If you's not willing to open an issue, maybe simply leave a comment in the file stating that it should provide a program but that nothing is installed in |
Thanks @GaetanLepage ! I have added a comment in the file. For now I'm not opening an issue upstream. |
|
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.