Skip to content

Comments

ashell: 0.4.0 -> 0.4.1#392108

Merged
h7x4 merged 1 commit intoNixOS:masterfrom
Daru-san:ashell-update
Apr 4, 2025
Merged

ashell: 0.4.0 -> 0.4.1#392108
h7x4 merged 1 commit intoNixOS:masterfrom
Daru-san:ashell-update

Conversation

@Daru-san
Copy link
Contributor

@Daru-san Daru-san commented Mar 22, 2025

Updated ashell from 0.4.0 to 0.4.1.
Changelog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392108


x86_64-linux

❌ 1 package failed to build:
  • ashell

@ddogfoodd
Copy link
Contributor

that might have fixed it, will try to build again

@Daru-san
Copy link
Contributor Author

I added the udev and vulkan-loader dependencies to match the upstream flake package.
Build should succeed now.

@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392108


x86_64-linux

✅ 1 package built:
  • ashell

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 22, 2025
Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392108


x86_64-linux

✅ 1 package built:
  • ashell

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 1, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5351

@h7x4 h7x4 merged commit f0ad544 into NixOS:master Apr 4, 2025
29 checks passed
Daru-san added a commit to Daru-san/SnowyDots that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants