Skip to content

Comments

python3Packages.pyqt5: correct mesa dependency#392128

Merged
K900 merged 1 commit intoNixOS:masterfrom
bengsparks:pyqt5-dep-fix
Mar 23, 2025
Merged

python3Packages.pyqt5: correct mesa dependency#392128
K900 merged 1 commit intoNixOS:masterfrom
bengsparks:pyqt5-dep-fix

Conversation

@bengsparks
Copy link
Contributor

python3Packages.pyqt5 declares a dependency on a mesa package for purpose of inheriting its meta platforms field.
Due to its placement in pkgs/development/python-modules, this mesa reference instead resolves to python3Packages.mesa, not pkgs.mesa.

As python3Packages.mesa is a 'Agent-based modeling framework', I suspect this package intended to refer to pkgs.mesa instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`python3Packages.pyqt5` declares a dependency on a `mesa` package for purpose of
inheriting its meta platforms field.
Due to its placement in `pkgs/development/python-modules`, this `mesa`
reference instead resolves to `python3Packages.mesa`, not `pkgs.mesa`.

As `python3Packages.mesa` is a 'Agent-based modeling framework', I
suspect this package intended to refer to `pkgs.mesa` instead.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 22, 2025
@nix-owners nix-owners bot requested a review from natsukium March 22, 2025 15:44
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 22, 2025
@NickCao NickCao requested a review from K900 March 23, 2025 13:29
@K900 K900 merged commit 575b362 into NixOS:master Mar 23, 2025
26 of 27 checks passed
@bengsparks bengsparks deleted the pyqt5-dep-fix branch March 23, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants