Skip to content

gotestsum: 1.12.0-unstable-2024-09-17 -> 1.12.1 #392148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pbsds merged 1 commit into from
Apr 19, 2025
Merged

gotestsum: 1.12.0-unstable-2024-09-17 -> 1.12.1 #392148

pbsds merged 1 commit into from
Apr 19, 2025
+8 −13

Conversation

@isabelroses
Copy link
Member

@isabelroses isabelroses commented Mar 22, 2025

supersedes #349366 which had issues with darwin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@isabelroses isabelroses added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Mar 23, 2025
jopejoe1
jopejoe1 reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the git rev not be changed to a git tag?

@isabelroses
Copy link
Member Author

isabelroses commented Mar 28, 2025 •
edited
Loading

Should the git rev not be changed to a git tag?

Ops seems i forgot to push that lol

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 28, 2025
@pbsds pbsds merged commit 6241d11 into NixOS:master Apr 19, 2025
28 checks passed
@wegank wegank mentioned this pull request Apr 19, 2025
Closed
13 tasks
@isabelroses isabelroses deleted the gotestsum branch April 19, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 left review comments

+1 more reviewer

@thefossguy thefossguy thefossguy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isabelroses @jopejoe1 @thefossguy @pbsds