Skip to content

Conversation

@petrzjunior
Copy link
Contributor

Update to the lastest commit. Silence implicit-function-declaration, incompatible-pointer-types to fix GCC 14 build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@nix-owners nix-owners bot requested a review from bcdarwin March 22, 2025 16:58
@azuwis
Copy link
Contributor

azuwis commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392153


aarch64-linux

✅ 1 package built:
  • mni_autoreg

x86_64-linux

✅ 1 package built:
  • mni_autoreg

aarch64-darwin

✅ 1 package built:
  • mni_autoreg

x86_64-darwin

✅ 1 package built:
  • mni_autoreg

@bcdarwin
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392153


x86_64-linux

✅ 1 package built:
  • mni_autoreg

Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 25, 2025
@petrzjunior petrzjunior changed the title mni_autoreg: unstable-2022-05-20 -> unstable-2024-10-04, unbreak on GCC 14 mni_autoreg: unstable-2022-05-20 -> 0.99.70-unstable-2024-10-04, unbreak on GCC 14 Mar 25, 2025
@FliegendeWurst FliegendeWurst merged commit 6e78ba8 into NixOS:master Mar 29, 2025
35 checks passed
@petrzjunior petrzjunior deleted the mni_autoreg branch March 29, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants