Skip to content

Comments

lime3ds: remove; azahar: init at 2120.1#392184

Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom
arthsmn:azahar-emulator
Mar 23, 2025
Merged

lime3ds: remove; azahar: init at 2120.1#392184
GaetanLepage merged 2 commits intoNixOS:masterfrom
arthsmn:azahar-emulator

Conversation

@arthsmn
Copy link
Member

@arthsmn arthsmn commented Mar 22, 2025

Removed the lime3ds emulator, which was deprecated, with the newer azahar emulator, adding an alias to help migration.

Homepage of azahar: https://github.com/azahar-emu/azahar/tree/master

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@arthsmn
Copy link
Member Author

arthsmn commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392184


x86_64-linux

✅ 1 package built:
  • azahar

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392184


x86_64-linux

✅ 1 package built:
  • azahar

aarch64-linux

✅ 1 package built:
  • azahar

@GaetanLepage GaetanLepage requested a review from NickCao March 22, 2025 22:32
project was superseeded by 'azahar'.
@arthsmn arthsmn requested a review from NickCao March 22, 2025 23:17
@arthsmn arthsmn changed the title lime3ds: remove; azahar: init at 2120 lime3ds: remove; azahar: init at 2120.1 Mar 22, 2025
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, please test to make sure enableQt still works as expected!

@arthsmn
Copy link
Member Author

arthsmn commented Mar 22, 2025

Diff LGTM, please test to make sure enableQt still works as expected!

I've tested it and it works.

@GaetanLepage
Copy link
Contributor

[100%] Built target citra_meta
Install the project...
-- Install configuration: "Release"
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/bin/azahar
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/bin/azahar-room
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/share/applications/azahar.desktop
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/share/icons/hicolor/scalable/apps/azahar.svg
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/share/icons/hicolor/512x512/apps/azahar.png
-- Installing: /nix/store/1r35s31m23nzlks3qpibdq4kh2z5fpma-azahar-2120.1/share/mime/packages/azahar.xml
/nix/store/1r78mr4ghlswpbg6kidrcywdwdyr9np0-stdenv-linux/setup: eval: line 273: syntax error: unexpected end of file

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392184


x86_64-linux

❌ 1 package failed to build:
  • azahar

aarch64-linux

❌ 1 package failed to build:
  • azahar

@arthsmn
Copy link
Member Author

arthsmn commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392184


x86_64-linux

✅ 1 package built:
  • azahar

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392184


x86_64-linux

✅ 1 package built:
  • azahar

aarch64-linux

✅ 1 package built:
  • azahar

@GaetanLepage GaetanLepage merged commit e448c1c into NixOS:master Mar 23, 2025
25 of 27 checks passed
@arthsmn arthsmn deleted the azahar-emulator branch March 23, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants