Skip to content

Comments

ibus-table-chinese: Fix missing share/ibus-table#392193

Closed
Chan-Siu-Man wants to merge 2 commits intoNixOS:masterfrom
Chan-Siu-Man:ibus-table-chinese/fix-missing-ibus-table
Closed

ibus-table-chinese: Fix missing share/ibus-table#392193
Chan-Siu-Man wants to merge 2 commits intoNixOS:masterfrom
Chan-Siu-Man:ibus-table-chinese/fix-missing-ibus-table

Conversation

@Chan-Siu-Man
Copy link
Contributor

Fix #392191.

Add postInstall to copy share/ibus-table.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2025
@nix-owners nix-owners bot requested a review from kliu128 March 22, 2025 20:43
Replace ad-hoc `preBuild` and `postFixup` with `writableTmpDirAsHomeHook`.
@Chan-Siu-Man
Copy link
Contributor Author

Obsoleted by #392427, which bumps ibus-chinese-table to 1.8.12 and fixes cmake builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ibus-table-chinese: missing tables db and icons under share/ibus-table

3 participants