Skip to content

Comments

authelia: fix session termination bug#392258

Merged
pbsds merged 1 commit intoNixOS:masterfrom
JayRovacsek:392231-fix
Apr 7, 2025
Merged

authelia: fix session termination bug#392258
pbsds merged 1 commit intoNixOS:masterfrom
JayRovacsek:392231-fix

Conversation

@JayRovacsek
Copy link
Contributor

@JayRovacsek JayRovacsek commented Mar 23, 2025

This changeset resolves #392231 by introducing the added environment variable to the go build environment as was introduced in the package source repository

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2025
@nix-owners nix-owners bot requested review from 06kellyjac, dit7ya and nicomem March 23, 2025 03:17
@JayRovacsek JayRovacsek force-pushed the 392231-fix branch 2 times, most recently from 7acd2fa to 39b2c24 Compare March 23, 2025 09:00
@nicomem nicomem added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 23, 2025
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be handy but I'd rather get this merged and fixed 🙂
We can always find the reasoning from the git blame

Copy link
Contributor

@hatch01 hatch01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hatch01
Copy link
Contributor

hatch01 commented Apr 2, 2025

What is this PR waiting for to be merged?
This is very problematic to use authelia now.

@JayRovacsek
Copy link
Contributor Author

Sorry to ping @SuperSandro2000 @dit7ya - this is causing the package behaviour to become unusabe, if you'd mind reviewing 🙏

@hatch01
Copy link
Contributor

hatch01 commented Apr 6, 2025

https://forge.onyx.ovh/eymeric/flake/commit/e945e8f3f6bc6acd0fbf3b266a50d7238615baea
If it can help someone until reviewers have time to merge the pr

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 6, 2025
@pbsds pbsds merged commit 264cf20 into NixOS:master Apr 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

authelia: session retrieval failure

7 participants