Conversation
contains fixes for some bugs I reported
teto
commented
Mar 23, 2025
pkgs/by-name/pi/pimsync/package.nix
Outdated
| cargoHash = "sha256-QRbjv8k7JEktHjfwJGwVReu9lynB817edsyClOoAwoA="; | ||
| cargoHash = "sha256-/6YjyKB/xOCTNZlKewddEaZ1ZN2PC5dQoP0A5If67MA="; | ||
|
|
||
| PIMSYNC_VERSION = version; |
Member
Author
There was a problem hiding this comment.
this should be finalAttrs.version or somewhat. Is that even mandatory ?
Contributor
There was a problem hiding this comment.
finalAttrs is preferred, switching to it would be good
Member
There was a problem hiding this comment.
@teto sure you can make a separate commit for that
do that and done
github-actions
bot
added
10.rebuild-darwin: 1
such that overriding 'version' get reflected in 'pimsync version'. See 'https://todo.sr.ht/~whynothugo/pimsync/169'
Contributor
|
0xda157
approved these changes
Mar 23, 2025
0xda157
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains fixes for some bugs I reported
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.