Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
bjornfor
approved these changes
Mar 23, 2025
lzcunt
approved these changes
Mar 23, 2025
Member
lzcunt
left a comment
lzcunt
left a comment
There was a problem hiding this comment.
Funnily enough I encountered this just today, thanks
drupol
requested changes
Mar 23, 2025
Contributor
drupol
left a comment
drupol
left a comment
There was a problem hiding this comment.
Can you please don't move the attribute platforms which seems to be at the right place and only add mainProgram just before maintainers ?
Also, the commit log message and the PR title should be:
busybox: set `meta.mainProgram`
Fix this warning: > evaluation warning: getExe: Package "busybox-1.36.1" does not have > the meta.mainProgram attribute.
concatime
force-pushed
the
set-main-program-of-busybox
branch
from
086097b to
781bed2
Compare
Contributor
Author
|
I initially sorted the meta attributes as listed in the documentation, but I reverted my change as you asked. |
drupol
approved these changes
Mar 23, 2025
wegank
added
the
12.approvals: 3+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this warning:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.