Skip to content

Comments

apacheKafka: init at 4.0.0#392450

Merged
srhb merged 3 commits intoNixOS:masterfrom
jpds:apache-kafka-4.0.0
Mar 27, 2025
Merged

apacheKafka: init at 4.0.0#392450
srhb merged 3 commits intoNixOS:masterfrom
jpds:apache-kafka-4.0.0

Conversation

@jpds
Copy link
Contributor

@jpds jpds commented Mar 23, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jpds jpds requested a review from srhb March 23, 2025 17:09
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 23, 2025
@jpds jpds requested a review from SuperSandro2000 March 23, 2025 17:09
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2025
@nix-owners nix-owners bot requested a review from ragnard March 23, 2025 17:17
@srhb
Copy link
Contributor

srhb commented Mar 24, 2025

Looks great, but should we maybe add a release note now that the the default apacheKafka version only supports KRaft? I assume people will have to migrate manually before upgrading, and I'm unsure what the failure mode looks like.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Mar 24, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2025
@srhb srhb merged commit 7d4bcd6 into NixOS:master Mar 27, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants