Skip to content

Comments

valkey: remove rucadi from maintainers#392451

Merged
drupol merged 1 commit intoNixOS:masterfrom
NyCodeGHG:valkey-drop-rucadi
Mar 23, 2025
Merged

valkey: remove rucadi from maintainers#392451
drupol merged 1 commit intoNixOS:masterfrom
NyCodeGHG:valkey-drop-rucadi

Conversation

@NyCodeGHG
Copy link
Member

They no longer wish to be a maintainer for valkey. See #387010 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

They no longer wish to be a maintainer for valkey.
See NixOS#387010 (comment)
@donovanglover donovanglover added 12.approvals: 1 This PR was reviewed and approved by one person. and removed backport release-24.11 labels Mar 23, 2025
@donovanglover
Copy link
Member

Seems like we added labels at the same time which is why the backport label was accidentally removed

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 23, 2025
@drupol drupol merged commit f6cd24f into NixOS:master Mar 23, 2025
26 of 30 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 23, 2025

Successfully created backport PR for release-24.11:

@NyCodeGHG NyCodeGHG deleted the valkey-drop-rucadi branch March 23, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants