Skip to content

Comments

python3Packages.dash: 2.18.2 -> 3.0.0#392456

Merged
TomaSajt merged 2 commits intoNixOS:masterfrom
LordGrimmauld:dash-3
Mar 25, 2025
Merged

python3Packages.dash: 2.18.2 -> 3.0.0#392456
TomaSajt merged 2 commits intoNixOS:masterfrom
LordGrimmauld:dash-3

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Mar 23, 2025

Diff: plotly/dash@refs/tags/v2.18.2...v3.0.0

Changelog: https://github.com/plotly/dash/blob/refs/tags/v3.0.0/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 23, 2025
@LordGrimmauld
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392456 --checkout commit


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • picosnitch
  • picosnitch.dist
❌ 2 packages failed to build:
  • das
  • das.dist
✅ 18 packages built:
  • prowler
  • prowler.dist
  • python312Packages.dash
  • python312Packages.dash-bootstrap-components
  • python312Packages.dash-bootstrap-components.dist
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python312Packages.dash.dist
  • python312Packages.meshtastic
  • python312Packages.meshtastic.dist
  • python313Packages.dash
  • python313Packages.dash-bootstrap-components
  • python313Packages.dash-bootstrap-components.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist
  • python313Packages.dash.dist
  • python313Packages.meshtastic
  • python313Packages.meshtastic.dist

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 23, 2025
@nix-owners nix-owners bot requested review from TomaSajt and antoinerg March 23, 2025 17:48
@TomaSajt
Copy link
Contributor

Seems like this broke das.
Consider adding "dash" to pythonRelaxDeps in pkgs/by-name/da/das/package.nix.

Otherwise, LGTM.

@LordGrimmauld
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392456 --checkout commit


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • picosnitch
  • picosnitch.dist
✅ 20 packages built:
  • das
  • das.dist
  • prowler
  • prowler.dist
  • python312Packages.dash
  • python312Packages.dash-bootstrap-components
  • python312Packages.dash-bootstrap-components.dist
  • python312Packages.dash-bootstrap-templates
  • python312Packages.dash-bootstrap-templates.dist
  • python312Packages.dash.dist
  • python312Packages.meshtastic
  • python312Packages.meshtastic.dist
  • python313Packages.dash
  • python313Packages.dash-bootstrap-components
  • python313Packages.dash-bootstrap-components.dist
  • python313Packages.dash-bootstrap-templates
  • python313Packages.dash-bootstrap-templates.dist
  • python313Packages.dash.dist
  • python313Packages.meshtastic
  • python313Packages.meshtastic.dist

@LordGrimmauld
Copy link
Contributor Author

good call, fixed

@nix-owners nix-owners bot requested a review from fabaff March 23, 2025 18:21
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
let's wait for the CI though

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 23, 2025
@TomaSajt TomaSajt merged commit cb1b8cc into NixOS:master Mar 25, 2025
29 checks passed
@TomaSajt
Copy link
Contributor

Ah I just saw that the 3.0.1 version was released which removed the stringcase dependency again...

@LordGrimmauld
Copy link
Contributor Author

wow.... amazing upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants