Skip to content

Comments

readest: 0.9.23 -> 0.9.28#392500

Merged
FliegendeWurst merged 6 commits intoNixOS:masterfrom
ddogfoodd:update-readest
Mar 31, 2025
Merged

readest: 0.9.23 -> 0.9.28#392500
FliegendeWurst merged 6 commits intoNixOS:masterfrom
ddogfoodd:update-readest

Conversation

@ddogfoodd
Copy link
Contributor

@ddogfoodd ddogfoodd commented Mar 23, 2025 •
edited
Loading

Changelog: https://github.com/readest/readest/releases/tag/v0.9.28
Diff: readest/readest@v0.9.23...v0.9.28

also switching to final.Attrs

add @eljamm as maintainer

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2025
0xda157
0xda157 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2025
@ddogfoodd ddogfoodd marked this pull request as draft March 26, 2025 16:48
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 26, 2025

0.9.26 released, building and testing rn

@ddogfoodd ddogfoodd changed the title readest: 0.9.23 -> 0.9.25 readest: 0.9.23 -> 0.9.26 Mar 26, 2025
@ddogfoodd ddogfoodd marked this pull request as ready for review March 26, 2025 17:06
@ddogfoodd ddogfoodd requested a review from 0xda157 March 26, 2025 17:06
0xda157
0xda157 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff still lgtm

@ddogfoodd ddogfoodd marked this pull request as draft March 26, 2025 19:04
@ddogfoodd ddogfoodd marked this pull request as ready for review March 26, 2025 19:32
@ddogfoodd ddogfoodd requested a review from 0xda157 March 26, 2025 19:32
@eljamm
Copy link
Contributor

eljamm commented Mar 29, 2025

I'm interested in picking up this package, so could you please add me to its maintainers, @ddogfoodd?

PS: version 0.9.27 just came out.

@ddogfoodd ddogfoodd marked this pull request as draft March 29, 2025 09:19
@ddogfoodd ddogfoodd changed the title readest: 0.9.23 -> 0.9.26 readest: 0.9.23 -> 0.9.27 Mar 29, 2025
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025

Do I have to squash commits in this case? Or just for trivial changes like removing whitespace or formatting?

@ddogfoodd ddogfoodd marked this pull request as ready for review March 29, 2025 09:41
@ddogfoodd ddogfoodd requested a review from 0xda157 March 29, 2025 09:41
@kirillrdy
Copy link
Member

kirillrdy commented Mar 29, 2025 •
edited
Loading

you can squash if you wish, it's not required. main requirement is that each commit must eval

@eljamm
Copy link
Contributor

eljamm commented Mar 29, 2025

Do I have to squash commits in this case? Or just for trivial changes like removing whitespace or formatting?

I think it's fine here since each commit describes a unique/logical change. I've seen separate commits for formatting, before, but for small fixups and changes that belong together, it's best to squash.

eljamm
eljamm approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025

Thank you for explaining!

@eljamm
Copy link
Contributor

eljamm commented Mar 29, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392500

x86_64-linux

❌ 1 package failed to build:
  • readest

aarch64-linux

❌ 1 package failed to build:
  • readest

There is apparently some hash mismatch (see logs)

@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025 •
edited
Loading

weird, I tried building and executing, both went well. will try again with nixpkgs-review

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 29, 2025
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392500

x86_64-linux

✅ 1 package built:
  • readest

@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025

works for me on x86_64-linux, not sure what to do now

@eljamm
Copy link
Contributor

eljamm commented Mar 29, 2025 •
edited
Loading

It works for me too, locally. Guess this was just the fault of the GitHub actions nixpkgs-review I was using. Tried it with another one and it's currently building it.

eljamm
eljamm approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392500

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14144963714

x86_64-linux

✅ 1 package built:
  • readest

aarch64-linux

✅ 1 package built:
  • readest

0xda157
0xda157 approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddogfoodd ddogfoodd marked this pull request as draft March 29, 2025 18:59
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Mar 29, 2025

guess what, 0.9.28 just dropped, building and testing now

@ddogfoodd ddogfoodd changed the title readest: 0.9.23 -> 0.9.27 readest: 0.9.23 -> 0.9.28 Mar 29, 2025
@ddogfoodd ddogfoodd marked this pull request as ready for review March 29, 2025 19:22
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Mar 29, 2025
eljamm
eljamm approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392500

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/14150002762

x86_64-linux

✅ 1 package built:
  • readest

aarch64-linux

✅ 1 package built:
  • readest

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 29, 2025
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 30, 2025
@FliegendeWurst FliegendeWurst merged commit 83c600d into NixOS:master Mar 31, 2025
56 of 57 checks passed
@ddogfoodd ddogfoodd deleted the update-readest branch March 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@eljamm eljamm eljamm approved these changes

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ddogfoodd @eljamm @kirillrdy @0xda157 @wegank @FliegendeWurst