Skip to content

Comments

nixos/xrdp: use --replace-fail with substituteInPlace, try #2#392512

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:xrdp-2
Jul 1, 2025
Merged

nixos/xrdp: use --replace-fail with substituteInPlace, try #2#392512
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:xrdp-2

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 23, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 23, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2025
@spiage
Copy link

spiage commented Mar 23, 2025

Am I do it right? =)
inputs.nixpkgs.url = "github:NixOS/nixpkgs/8fd6f7314022495031fddfac492d37c995bd90bb";

@spiage
Copy link

spiage commented Mar 23, 2025

$ nix-env -p /nix/var/nix/profiles/system --set /nix/store/9jc8ic27qpfcbpbz148vpaghdn02q2x2-nixos-system-a7-25.05.20250323.8fd6f73
$ systemd-run -E LOCALE_ARCHIVE -E NIXOS_INSTALL_BOOTLOADER= --collect --no-ask-password --pipe --quiet --service-type=exec --unit=nixos-rebuild-switch-to-configuration --wait true
Using systemd-run to switch configuration.
$ systemd-run -E LOCALE_ARCHIVE -E NIXOS_INSTALL_BOOTLOADER= --collect --no-ask-password --pipe --quiet --service-type=exec --unit=nixos-rebuild-switch-to-configuration --wait /nix/store/9jc8ic27qpfcbpbz148vpaghdn02q2x2-nixos-system-a7-25.05.20250323.8fd6f73/bin/switch-to-configuration switch
stopping the following units: accounts-daemon.service, systemd-tmpfiles-resetup.service, udisks2.service, xrdp.service
NOT restarting the following changed units: libvirtd.service, systemd-fsck@dev-disk-by\x2duuid-42EA\x2d18D7.service, xrdp-sesman.service
activating the configuration...
setting up /etc...
restarting systemd...
reloading user units for spiage...
restarting sysinit-reactivation.target
reloading the following units: dbus.service
restarting the following units: polkit.service, systemd-udevd.service
starting the following units: accounts-daemon.service, systemd-tmpfiles-resetup.service, udisks2.service, xrdp.service
the following new units were started: NetworkManager-dispatcher.service
Done. The new configuration is /nix/store/9jc8ic27qpfcbpbz148vpaghdn02q2x2-nixos-system-a7-25.05.20250323.8fd6f73

@SuperSandro2000
Copy link
Member Author

@spiage yep, I think so. So this worked from your side?

@spiage
Copy link

spiage commented Jul 1, 2025

Hi!
I'm still using the old version, but will try to switch after it 'll be merged into master
https://github.com/spiage/nixos-config/blob/ac99df95571f23fde8960269f146e0ad37f2b13b/flake.nix#L9

@SuperSandro2000 SuperSandro2000 merged commit ace047b into NixOS:master Jul 1, 2025
51 checks passed
@SuperSandro2000 SuperSandro2000 deleted the xrdp-2 branch July 1, 2025 09:59
@spiage
Copy link

spiage commented Jul 1, 2025

[C*]  #124  xorg-server             21.1.16 x2 -> 21.1.16
[C.]  #125  xorgproto               2024.1 x2 -> 2024.1
[U.]  #126  xorgxrdp                0.10.2 -> 0.10.4
[U.]  #127  xrdp                    0.10.1 -> 0.10.3

xrdp worked fine for my system now from nixpkgs/master, after reboot and reconnect too
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants