sshd: fewer empty lines in generated config#392527
Merged
r-vdp merged 1 commit intoNixOS:stagingfrom Sep 24, 2025
Merged
Conversation
github-actions
bot
added
6.topic: nixos
wegank
added
the
2.status: merge conflict
Contributor
|
I like this! Could you rebase on top of master? If not, I don't mind doing it myself either. |
Member
Author
|
please go ahead. I am adapting my workflow to https://jj-vcs.github.io/ and while I managed to rebase,I seem to have a big diff, mostly around whitespaces and i am not sure if it's expected or not. |
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
2 times, most recently
from
491cebc to
a25bd13
Compare
ofborg
bot
removed
the
2.status: merge conflict
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
from
a25bd13 to
027c7f3
Compare
wegank
added
the
2.status: merge conflict
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
from
027c7f3 to
8e0841a
Compare
r-vdp
removed
the
2.status: merge conflict
Member
Author
|
I am reluctant to merge anything related to ssh (and it would be a shameful self-merge on top-of that). I believe it looks ok ? |
nixpkgs-ci
bot
added
the
9.needs: reviewer
Member
Author
|
bump for review/merge |
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
from
8e0841a to
416b18b
Compare
r-vdp
approved these changes
Sep 19, 2025
Contributor
r-vdp
left a comment
r-vdp
left a comment
There was a problem hiding this comment.
LGTM! I have been using this on my machines for several months now without issues.
nixpkgs-ci
bot
added
12.approvals: 1
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
from
416b18b to
affaff1
Compare
NyCodeGHG
previously requested changes
Sep 19, 2025
Co-authored-by: r-vdp <ramses@well-founded.dev> Co-authored-by: Marie <tabmeier12@gmail.com>
r-vdp
force-pushed
the
teto/ssh-config-fewer-newlines
branch
from
944f2a4 to
7ebfdde
Compare
r-vdp
dismissed
NyCodeGHG’s stale review
Requested changes were incorporated
This comment has been minimized.
This comment has been minimized.
NyCodeGHG
approved these changes
Sep 22, 2025
Contributor
|
@qweered I don't think nixpkgs review is meaningful for changes to modules, since no packages are affected by this. |
nixpkgs-ci
bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.