Skip to content

Comments

ticktick: add arm package#392601

Merged
FliegendeWurst merged 2 commits intoNixOS:masterfrom
jonocodes:ticktick-arm64
Mar 25, 2025
Merged

ticktick: add arm package#392601
FliegendeWurst merged 2 commits intoNixOS:masterfrom
jonocodes:ticktick-arm64

Conversation

@jonocodes
Copy link
Contributor

@jonocodes jonocodes commented Mar 24, 2025

This adds aarch64 support for ticktick so it can be used in asahi.
This PR replaces #391709

Closes #391709

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Mar 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@nix-owners nix-owners bot requested a review from hbjydev March 24, 2025 02:50
@jonocodes jonocodes mentioned this pull request Mar 24, 2025
13 tasks
@FliegendeWurst
Copy link
Member

Please read https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions :)

(or check my review in the previous PR)

@jonocodes
Copy link
Contributor Author

Please read https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions :)

(or check my review in the previous PR)

Ok, thanks I have just read that section. But I am still confused.

Regarding your previous comment:

"1. PR must be made by r-ryantm or a committer"

It this referring to adding me to maintainers? If so, do I reach out to an existing committer to create a separate PR to join me to maintainers?

"2. PR must only change files in pkgs/by-name"

So this means, my package update should not be in the same PR as updating maintainers? I originally made a separate PR to add me to maintainers, but was told that should be in this same package update PR. #391731

Thanks.

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 24, 2025

Oh, I was referring to #391709 (review)

Basically you need to reword the commit messages.

(The whole discussion about the merge bot was more directed at the maintainer who tried to use it.)

@jonocodes
Copy link
Contributor Author

@hbjydev I think this means you can now approve this?

@FliegendeWurst
Copy link
Member

There should be two commits, named exactly:

  • maintainers: add jonocodes
  • ticktick: add aarch64 binary

As required per https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

That's really the only thing left on this PR. Maintainer approval was given in last PR already.

@jonocodes
Copy link
Contributor Author

ok, I have rewritten the 2 commit messages exactly in both this PR and the original one.

@FliegendeWurst FliegendeWurst merged commit 421b634 into NixOS:master Mar 25, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants