ticktick: add arm package#392601
Conversation
cf0419e to
02b957c
Compare
|
Please read https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions :) (or check my review in the previous PR) |
Ok, thanks I have just read that section. But I am still confused. Regarding your previous comment: "1. PR must be made by r-ryantm or a committer" It this referring to adding me to maintainers? If so, do I reach out to an existing committer to create a separate PR to join me to maintainers? "2. PR must only change files in pkgs/by-name" So this means, my package update should not be in the same PR as updating maintainers? I originally made a separate PR to add me to maintainers, but was told that should be in this same package update PR. #391731 Thanks. |
|
Oh, I was referring to #391709 (review) Basically you need to reword the commit messages. (The whole discussion about the merge bot was more directed at the maintainer who tried to use it.) |
|
@hbjydev I think this means you can now approve this? |
|
There should be two commits, named exactly:
As required per https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions That's really the only thing left on this PR. Maintainer approval was given in last PR already. |
02b957c to
88e4286
Compare
88e4286 to
e11c2cd
Compare
|
ok, I have rewritten the 2 commit messages exactly in both this PR and the original one. |
This adds aarch64 support for ticktick so it can be used in asahi.
This PR replaces #391709
Closes #391709
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.