tectonic-unwrapped: fix build with icu 75#392621
Conversation
|
Works, except it seems texpresso needs to be updated.
|
|
@stephen-huan Thank you very much for the review! I pushed a new version which saves us from vendoring the patch. Can you see if the newer version also works? I will look into the texpresso failure. |
|
Seems texpresso works now, nice.
|
stephen-huan
left a comment
There was a problem hiding this comment.
Works for me (see nixpkgs-review in #392621 (comment)).
As mentioned in #392552 (comment), it's 009de06 (#386191) which breaks it but this fix is probably even cleaner than trying to figure out the interaction with clang.
doronbehar
left a comment
There was a problem hiding this comment.
Diff LGTM. Well done on the investigation @bryango !
Fixes #392552.
I have found a way to cherry-pick the necessary patches from upstream's master.
The patch has to be vendored due to some trivial whitespace differences that prevent it to apply directly. This is fixed by hand in the second commit (the first commit contains only the original, unmodified patch).Build success: https://github.com/bryango/nix-build-action/actions/runs/14028664706/job/39271728385
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.