freerdp: drop freerdp 2.x, move to by-name

[LordGrimmauld]

The freerdp package name previuously pointed to the unmaintained freerdp version 2.x. Version 2.x is no longer used in nixpkgs.
It was never clear freerdp would be pinned to 2.x versions indefinitely.

This removes the pin on the freerdp package and moves the package to by-name pattern.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[LordGrimmauld]

There is also an argument to be made to build freerdp against sdl3, but that is an actual functionality change. CI should say zero rebuilds on this, the sdl dependency bump will come in yet another followup.

[alyssais]

The commit ordering isn't ideal, because in the middle of the two commits we have packages depending on an alias. Could it be structured as follows?

1. Point freerdp to 3
2. treewide to use unversioned freerdp
3. Remove freerdp2 and move freerdp3 to be an alias

[LordGrimmauld]

The commit ordering isn't ideal, because in the middle of the two commits we have packages depending on an alias. Could it be structured as follows?

1. Point freerdp to 3

2. treewide to use unversioned freerdp

3. Remove freerdp2 and move freerdp3 to be an alias

dropping freerdp2 can happen whenever, nothing actually depends on it. But fixed the history to be bisectable

[alyssais]

Looks good but now has a conflict that needs to be resolved.

[LordGrimmauld]

Ok this should be fine now

[LordGrimmauld]

Ok huh? I blundered - turns out krdc and krdp did use freerdp2?? i did grep through the repo, i really do wonder why i missed that.... Now this is awkward. Sorry, absolutely my fault! Looking into a fix (that ideally isn't just a revert here).

[LordGrimmauld]

krdp: #393686
krdc is a bit more complex, working on it

[theCapypara]

Hello! I was just adding my app which requires freerdp2: #392984, this is now preventing it from compiling.

Edit: We discussed this over Matrix, I'll have to update the library that relies on FreeRDP 2 :(

[drupol]

This has broken Guacamole, issue #395919

[LordGrimmauld]

Right - so there are two breakages now? I guess i'll do a partial revert then....

[drupol]

Working on a fix @ #407726

[LordGrimmauld]

Working on a fix @ #407726

Thanks, fixes are preferred over reintroducing a 1-year-old version of a library that had security fixes.
If it doesn't work out, #407731 is an option too, basically only needs undraft and merge. But i'd rather not if at all possible.

[gbtb]

Hello. I'm considering the possibility to return freerdp version 2 to nixpkgs. Why the decision to remove v2 completely was made @LordGrimmauld ? In my practice, xfreerdp v3 has a broken clipboard support on KDE6+Wayland, while xfreerdp v2 works perfectly fine.

[alyssais]

Has the bug been reported upstream? We can't keep unmaintained software around forever — the path forward is to get a maintained version fixed.

[gbtb]

I haven't reported this exact bug upstream yet.
Looking further into available options with freerdp3, it seems to me that for usage with Wayland sdl-freerdp binary is recommended.
However, according to FreeRDP/FreeRDP#9399 (comment) clipboard support is only available with SDL3. Nixpkgs package still uses SDL2 and I checked that clipboard share indeed doesn't work.
I think I'll try to build our package with SDL3 and see if it works.

[LordGrimmauld]

We have #393673 to build freerdp against sdl3