Skip to content

Comments

below: replace vendored Cargo.lock patch with an upstream commit#392767

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
SigmaSquadron:push-suolmnmxqyov
Mar 24, 2025
Merged

below: replace vendored Cargo.lock patch with an upstream commit#392767
JohnRTitor merged 1 commit intoNixOS:masterfrom
SigmaSquadron:push-suolmnmxqyov

Conversation

@SigmaSquadron
Copy link
Contributor

Upstream updated their Cargo.lock in facebookincubator/below@f46f993. This is a followup PR to #390925.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@SigmaSquadron
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392767


x86_64-linux

✅ 1 package built:
  • below

@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392767

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14040615114


x86_64-linux

✅ 1 package built:
  • below

aarch64-linux

✅ 1 package built:
  • below

@JohnRTitor JohnRTitor merged commit d19e76a into NixOS:master Mar 24, 2025
23 of 27 checks passed
@SigmaSquadron SigmaSquadron deleted the push-suolmnmxqyov branch March 24, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants