Skip to content

Comments

pict-rs_0_3: remove leftover files#392772

Merged
NickCao merged 1 commit intoNixOS:masterfrom
TomaSajt:pict-rs
Mar 24, 2025
Merged

pict-rs_0_3: remove leftover files#392772
NickCao merged 1 commit intoNixOS:masterfrom
TomaSajt:pict-rs

Conversation

@TomaSajt
Copy link
Contributor

#336077 only added a throw to aliases.nix, but didn't remove the files

@emilazy

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

NixOS#336077 only added a throw to
aliases.nix, but didn't remove the files
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops thanks. I hope the throw takes precedence…

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Mar 24, 2025

There was no callPackage anymore, so precedence doesn't matter

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 24, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2025
@NickCao NickCao merged commit b20adf1 into NixOS:master Mar 24, 2025
25 of 28 checks passed
@TomaSajt TomaSajt deleted the pict-rs branch April 24, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants