Skip to content

Comments

{coppwr,pop-launcher,watchmate,wprs,meilisearch}: use fetchCargoVendor#392860

Merged
JohnRTitor merged 5 commits intoNixOS:masterfrom
TomaSajt:cargo-fix-symlink-deref-misc2
Mar 25, 2025
Merged

{coppwr,pop-launcher,watchmate,wprs,meilisearch}: use fetchCargoVendor#392860
JohnRTitor merged 5 commits intoNixOS:masterfrom
TomaSajt:cargo-fix-symlink-deref-misc2

Conversation

@TomaSajt
Copy link
Contributor

This PR migrates a few packages to use fetchCargoVendor.

There have been previous attempts at migrating larger chunks of packages, but I believe smaller chunks are more reviewable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@happysalada
Copy link
Contributor

This looks good to me. Can you please ping me in one week again, i just want to make sure everyone has had enough time to check.
Personally fine if anyone else merges.

@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392860

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14051390731


x86_64-linux

✅ 6 packages built:
  • coppwr
  • meilisearch
  • onagre
  • pop-launcher
  • watchmate
  • wprs

aarch64-linux

✅ 5 packages built:
  • coppwr
  • meilisearch
  • onagre
  • pop-launcher
  • watchmate

x86_64-darwin

✅ 1 package built:
  • meilisearch

aarch64-darwin

✅ 1 package built:
  • meilisearch

@happysalada
Copy link
Contributor

We have two approvals and one nixpkgs review, i think going beyond is a bit overkill, im going to merge, let me know if you think thats too fast, ill adjust my future behavior.

@happysalada
Copy link
Contributor

@TomaSajt we have comflicts when you have a moment

@happysalada
Copy link
Contributor

@TomaSajt we have conflicts when you have a moment

@TomaSajt TomaSajt force-pushed the cargo-fix-symlink-deref-misc2 branch from 13d350d to 1708b14 Compare March 25, 2025 18:27
@JohnRTitor JohnRTitor merged commit a2f6e0e into NixOS:master Mar 25, 2025
23 of 27 checks passed
@TomaSajt TomaSajt deleted the cargo-fix-symlink-deref-misc2 branch April 24, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants