{coppwr,pop-launcher,watchmate,wprs,meilisearch}: use fetchCargoVendor#392860
Merged
JohnRTitor merged 5 commits intoNixOS:masterfrom Mar 25, 2025
Merged
{coppwr,pop-launcher,watchmate,wprs,meilisearch}: use fetchCargoVendor#392860JohnRTitor merged 5 commits intoNixOS:masterfrom
JohnRTitor merged 5 commits intoNixOS:masterfrom
Conversation
Contributor
|
This looks good to me. Can you please ping me in one week again, i just want to make sure everyone has had enough time to check. |
Member
|
bbenno
approved these changes
Mar 25, 2025
samhug
approved these changes
Mar 25, 2025
Contributor
|
We have two approvals and one nixpkgs review, i think going beyond is a bit overkill, im going to merge, let me know if you think thats too fast, ill adjust my future behavior. |
Contributor
|
@TomaSajt we have comflicts when you have a moment |
Contributor
|
@TomaSajt we have conflicts when you have a moment |
13d350d to
1708b14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates a few packages to use fetchCargoVendor.
There have been previous attempts at migrating larger chunks of packages, but I believe smaller chunks are more reviewable.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.