Skip to content

Comments

rustPlatform.fetchCargoVendor: support lockfile v1#393016

Draft
TomaSajt wants to merge 1 commit intoNixOS:stagingfrom
TomaSajt:fetch-cargo-vendor-lockfile-v1
Draft

rustPlatform.fetchCargoVendor: support lockfile v1#393016
TomaSajt wants to merge 1 commit intoNixOS:stagingfrom
TomaSajt:fetch-cargo-vendor-lockfile-v1

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Mar 25, 2025

Closes #392872

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 25, 2025
@TomaSajt TomaSajt requested a review from alyssais March 25, 2025 12:43
@TomaSajt TomaSajt marked this pull request as draft March 25, 2025 12:58
@Koschi13
Copy link
Contributor

Koschi13 commented Jul 28, 2025

@TomaSajt would this PR ready to be merged?
I'd like to have these changes available on master so I can build a package which is still using the v1 lockfile

Thanks for the effort!

Koschi13 added a commit to Koschi13/nixpkgs that referenced this pull request Jul 29, 2025
@Koschi13
rustPlatform.fetchCargoVendor: Support v1 lockfile
12e47cf 
Version 1 lockfiles of `Cargo` were using a different metadata format
that the currently supported versions.
Through NixOS#392872 I stumbled across  NixOS#393016 whichs changes I included
here as they were outdated.
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais Awaiting requested review from alyssais

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomaSajt @Koschi13