Skip to content

Comments

cpr: init at 1.11.0#393020

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
phodina:cpr
May 16, 2025
Merged

cpr: init at 1.11.0#393020
Aleksanaa merged 1 commit intoNixOS:masterfrom
phodina:cpr

Conversation

@phodina
Copy link
Contributor

@phodina phodina commented Mar 25, 2025

Wrapper around libcurl

https://github.com/luxonis/cpr

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2025
@phodina
Copy link
Contributor Author

phodina commented Apr 25, 2025

@infinisil Could I ask you for review?

@phodina phodina mentioned this pull request Apr 26, 2025
Draft
13 tasks
@phodina
Copy link
Contributor Author

phodina commented May 12, 2025

@Pandapip1 would you have time for review to get over the DAI dependencies?

Pandapip1
Pandapip1 approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-written derivation, LGTM. Just one teensy tiny nitpick.

Pandapip1
Pandapip1 suggested changes May 12, 2025
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I missed this; this needs fixing

@phodina phodina requested a review from Pandapip1 May 13, 2025 16:51
@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 13, 2025
@Aleksanaa Aleksanaa merged commit f700ae2 into NixOS:master May 16, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phodina @Pandapip1 @Aleksanaa