Skip to content

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Mar 25, 2025

Release notes:

Resolves #392763 (issue requested 2025.02).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2025
@nix-owners nix-owners bot requested review from stigtsp and thoughtpolice March 25, 2025 09:30
@momeemt
Copy link
Member

momeemt commented Mar 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393022


aarch64-darwin

❌ 4 packages failed to build:
  • moarvm
  • nqp
  • rakudo
  • zef

@Prince213
Copy link
Member Author

Prince213 commented Mar 25, 2025

@momeemt Can't reproduce. Could you please share your logs?

@Prince213
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 393022

Logs: https://github.com/Prince213/nixpkgs-review-gha/actions/runs/14063001317


x86_64-darwin

✅ 4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

aarch64-darwin

✅ 4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@Prince213 Prince213 force-pushed the pkgs/rakudo-2025.03 branch from 965e62c to 05a889a Compare April 12, 2025 09:36
@Prince213 Prince213 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2025
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 12, 2025
@Aleksanaa Aleksanaa merged commit 1bcf479 into NixOS:master Apr 19, 2025
29 checks passed
@Prince213 Prince213 deleted the pkgs/rakudo-2025.03 branch November 25, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: rakudo 2025.01 → 2025.02

5 participants