Open
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
Author
|
@SigmaSquadron could I ask you for review? |
ethancedwards8
suggested changes
Apr 25, 2025
Contributor
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Seems pretty good overall, but the postInstall changes concern me a bit.
SigmaSquadron
approved these changes
Apr 27, 2025
Contributor
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Looks good to me! I'm sure that the commented-out sourceRoot could be replaced by some clever patchFlags tweaking, but I don't think it's worth it.
ethancedwards8
approved these changes
Apr 27, 2025
Contributor
Author
|
Sure it could be handled somehow but I'd rather spend the time to upstream the 2 patches and then just make it the default. |
wegank
added
the
12.approvals: 2
SigmaSquadron
requested changes
Aug 19, 2025
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foxglove WebSocket protocol specification and libraries
https://foxglove.dev/
NOTE: The patch is for Darwin where the
opensslandzlibare not found during linkingThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)