Skip to content

Comments

treewide: fix versionCheckProgramArg, from list to string#393030

Closed
drupol wants to merge 1 commit intoNixOS:stagingfrom
drupol:push-mmpvvtlrpono
Closed

treewide: fix versionCheckProgramArg, from list to string#393030
drupol wants to merge 1 commit intoNixOS:stagingfrom
drupol:push-mmpvvtlrpono

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Mar 25, 2025 •
edited
Loading

Created from #392857

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: php PHP is a general-purpose scripting language geared towards web development. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 25, 2025
@drupol drupol force-pushed the push-mmpvvtlrpono branch from 1949430 to 941429e Compare March 28, 2025 13:03
@drupol drupol force-pushed the push-mmpvvtlrpono branch from 941429e to 77b7fb0 Compare March 28, 2025 13:05
@drupol drupol changed the base branch from master to staging March 28, 2025 13:05
@drupol drupol marked this pull request as ready for review March 28, 2025 13:05
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 28, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@drupol drupol closed this Jun 14, 2025
@drupol drupol deleted the push-mmpvvtlrpono branch June 14, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@aanderse aanderse Awaiting requested review from aanderse

@mmahut mmahut Awaiting requested review from mmahut

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drupol @wegank