Skip to content

gst_all_1.gst-plugins-good: fix build for musl #393037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssais merged 1 commit into from
Mar 28, 2025
Merged

gst_all_1.gst-plugins-good: fix build for musl #393037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkgs/development/libraries/gstreamer/good/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ lib, stdenv
, fetchurl
, fetchpatch
, replaceVars
, meson
, nasm
Expand Down Expand Up @@ -74,6 +75,13 @@ stdenv.mkDerivation rec {
(replaceVars ./souploader.diff {
nixLibSoup3Path = "${lib.getLib libsoup_3}/lib";
})

(fetchpatch {
name = "musl.patch";
url = "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/dd1fc2b7931f5789815e17dda2ef7c31b9fba563.patch";
stripLen = 2;
Copy link
Member

@jtojnar jtojnar Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this is enough without extraPrefix = ""; to add a/ and b/ prefixes.

Copy link
Member Author

@alyssais alyssais Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because it leaves the "gst-plugins-good/" prefix, which functions the same as a/ and b/ would.

hash = "sha256-m2h1F6M2hzw3HxizmCyEEqkUQe0ccLWFBvgT2f+GjNE=";
})
];

strictDeps = true;
Expand Down