libcdio: refactor

[jopejoe1]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[toastal]

Are you sure you want to use fetchFromGitHub? While the current release didn’t properly mirror its tag, the GNU Savannah mirror has recent commits & the documentation says there should also be a code @ https://git.savannah.gnu.org/cgit/libcdio.git/refs/ If the tag was there, then you could have used https://git.savannah.gnu.org/cgit/libcdio.git/snapshot/libcdio-release-2.2.0.tar.gz as a secondary urls mirror link which would be better for all the times that Microsoft’s forge, GitHub, goes down. I emailed one of the maintainers to get feedback on whether or not the tag will be mirrored (which in hindsight I should have CCd you). If he messages back with a confirmation, I believe we should revert that commit & add the mirror as a fallback.

[jopejoe1]

Defintly want to use fetchFromGitHub as that is the most upstream source there is for this package.

[toastal]

I will wait a sec to hear back. It would be worthwhile that the GNU project has its GNU hosting in order (both philosophically & technically in case of outage). Also I found commit title errors: remove darwin frameworks → remove Darwin frameworks pkgCondigModules → pkgConfigModules

[jopejoe1]

corrected spelling in commit messages.

[toastal]

I haven’t heard back at this point, but if they get back, I will open a new request to add that mirror.

[misuzu]

Switching to fetchFromGitHub broke cross-compilation... I tried making it work with the fetchFromGitHub but unsuccessfully.
misuzu@169d105 this worked for me, should I open a PR or maybe you have some other suggestions?