Skip to content

Comments

fix hypergiant overrides#393168

Open
r14c wants to merge 6 commits intoNixOS:masterfrom
r14c:fix/chicken-hyperscene
Open

fix hypergiant overrides#393168
r14c wants to merge 6 commits intoNixOS:masterfrom
r14c:fix/chicken-hyperscene

Conversation

@r14c
Copy link

@r14c r14c commented Mar 25, 2025

chicken-hypergiant was marked as broken, I updated the overrides so it would build again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@r14c r14c changed the base branch from nixos-24.11 to master March 25, 2025 19:10
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 25, 2025
@nix-owners
Copy link

nix-owners bot commented Mar 25, 2025

The PR's base branch is set to master, but 7677 commits from the release-24.11 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-24.11 branch, change the base branch to release-24.11
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch:
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.11 HEAD)
    git rebase --onto 1d95cb5fa7a38717172e090d54338ca8daef8a86 f0946fa5f1fb876a9dc2e1850d9d3a4e3f914092
    git push --force-with-lease

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 25, 2025
@r14c r14c force-pushed the fix/chicken-hyperscene branch from 3ba9758 to 3795cc4 Compare March 25, 2025 19:14
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: vim Advanced text editor 6.topic: hardware Drivers, Firmware and Kernels 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: module system About "NixOS" module system internals 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: deepin 6.topic: dotnet Language: .NET 6.topic: nvidia Nvidia-specific issues and fixes 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: teams Relating to team creation, updates, other management actions and removed 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 25, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: teams Relating to team creation, updates, other management actions labels Mar 25, 2025
@r14c r14c changed the title fix hyperscene overrides fix hypergiant overrides Mar 26, 2025
@r14c r14c marked this pull request as draft March 26, 2025 05:03
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 26, 2025
@r14c r14c force-pushed the fix/chicken-hyperscene branch from ce146e5 to c61c524 Compare April 17, 2025 07:43
@r14c
Copy link
Author

r14c commented Apr 17, 2025

tested by building the demo example given in the hypergiant docs.

@r14c r14c marked this pull request as ready for review April 17, 2025 22:04
@r14c
Copy link
Author

r14c commented Apr 20, 2025

@corngood @konst-aa @nagy Sorry to bother, I'm new to contributing to nixpkgs. Any pointers you could give me to help this patch get merged?

@nagy
Copy link
Member

nagy commented Apr 20, 2025

You seem to be targeting more than just hypergiant. I would say a good start would be to have one commit for each package modification with a commit message as described here:

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

Thanks for the help.

@konst-aa
Copy link
Member

Hey, welcome!!

Thank you for putting up this contribution! I'd like to echo what Nagy said. Breaking up your PR into one commit per package + the naming conventions is the only thing missing right now. Then, I'll check if it builds on various systems. I'm about to get an Apple Silicon laptop, so I could also test it on Arm Darwin.

@r14c
Copy link
Author

r14c commented Apr 20, 2025

OK that makes sense. Fix up all of hypergiant's broken dependencies, then fix hypergiant itself.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@wolfgangwalther wolfgangwalther requested review from konst-aa and nagy July 4, 2025 17:10
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@konst-aa
Copy link
Member

konst-aa commented Jul 9, 2025

@wolfgangwalther @r14c Hey, following up. Thanks again for contributing! If you think it's ready, all that's missing is collapsing the commits and having them follow nixpkgs convention. You can find the examples for chicken in previous PRs / commits to files in ...compilers/chicken/5

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants