You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
The PR's base branch is set to master, but 7677 commits from the release-24.11 branch are included. Make sure you know the right base branch for your changes, then:
If the changes should go to the release-24.11 branch, change the base branch to release-24.11
If the changes should go to the master branch, rebase your PR onto the merge base with the master branch:
# git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-24.11 HEAD)
git rebase --onto 1d95cb5fa7a38717172e090d54338ca8daef8a86 f0946fa5f1fb876a9dc2e1850d9d3a4e3f914092
git push --force-with-lease
You seem to be targeting more than just hypergiant. I would say a good start would be to have one commit for each package modification with a commit message as described here:
Thank you for putting up this contribution! I'd like to echo what Nagy said. Breaking up your PR into one commit per package + the naming conventions is the only thing missing right now. Then, I'll check if it builds on various systems. I'm about to get an Apple Silicon laptop, so I could also test it on Arm Darwin.
@wolfgangwalther@r14c Hey, following up. Thanks again for contributing! If you think it's ready, all that's missing is collapsing the commits and having them follow nixpkgs convention. You can find the examples for chicken in previous PRs / commits to files in ...compilers/chicken/5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chicken-hypergiant was marked as broken, I updated the overrides so it would build again.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.