lilypond: modernise, enable docs

[eclairevoyant]

Things done

• lilypond: modernise
• lilypond: fix metadata
• lilypond: enable strictDeps
• lilypond-unstable: 2.25.24 -> 2.25.25; lilypond: switch to fetchzip

fixes #392943

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[yurrriq]

Looking good so far, thanks! If you @ me when it's ready, I'll do my best to test on my NixOS machine in a timely manner.

[eclairevoyant]

Will do, currently it doesn't build, I have to make some time to understand why.

[FliegendeWurst]

Probably you moved too much to nativeBuildInputs, boehmgc for example would be a runtime dependency I think.

[eclairevoyant]

boehmgc for example would be a runtime dependency I think.

True, but unrelated to the error, I believe. When I remove --disable-documentation, some script is running a binary that doesn't exist.

Please check the logfile

  /build/source/Documentation/out-/nix/store/d0hciavqzqrhhyjwzjr34f5cn47zwdh0-lilypond-2.24.4/en/generate-documentation.log

for errors. Last 20 lines:

Making Documentation/out-/nix/store/d0hciavqzqrhhyjwzjr34f5cn47zwdh0-lilypond-2.24.4/snippets/keyboards.itely 
Command: /build/source/out/bin/lilypond    --verbose    /build/source/ly/generate-documentation.ly

[marcin-serwin]

The script generating documentation fails because the Makefile uses out variable for a purpose different than the nix builder. You can fix it by explicitly resetting it to empty for make:

  makeFlags = [ "out=" ];

[marcin-serwin]

The package comes with the configure scripts generated, this and autoreconfHook can be removed

[FliegendeWurst]

autoreconfHook is often useful if the configure scripts gets too outdated. Not sure if it is needed in this case however.

[eclairevoyant]

I'll leave this as-is for now.

[yurrriq]

Thanks, @FliegendeWurst, @eclairevoyant, and reviewers. This is looking good to me. Would you agree, @FliegendeWurst, that this PR can now supersede #370259? I'm sorry we were so slow on that one. Thanks for your contributions and patience.

It seems we're good to merge this one now? Any lingering concerns?

[FliegendeWurst]

The Darwin build seems to be broken due to texi2html. (Undefined subroutine &Locale::Messages::dgettext called at /nix/store/7gybx31jp45fvn9xpp5s2w0m17kkc1hf-texi2html-5.0/bin/texi2html line 29628.) #224761

So it would be good to add configureFlags = lib.optionals stdenv.hostPlatform.isDarwin [ "--disable-documentation" ];

[FliegendeWurst]

Nevermind, the texi2html issue is indeed fixed by the "workaround" shared in that issue (it is not a workaround).

So this is good to go. I'll take care of texi2html