Skip to content

Comments

fishPlugins.pure: temporarily remove broken checks#393174

Closed
Kek5chen wants to merge 1 commit intoNixOS:masterfrom
Kek5chen:fix-pure
Closed

fishPlugins.pure: temporarily remove broken checks#393174
Kek5chen wants to merge 1 commit intoNixOS:masterfrom
Kek5chen:fix-pure

Conversation

@Kek5chen
Copy link
Contributor

Fixes #393104

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2025
@nix-owners nix-owners bot requested a review from pacien March 25, 2025 19:31
@JumpIn-Git
Copy link

JumpIn-Git commented Mar 26, 2025

thanks, imo checks should not be used when packaging a fish plugin; the tests are not for consumers, they are for the dev to test if their changes break anything. right now there doesnt seem to be any advantage to running the tests

@MarcelCoding
Copy link
Member

Checks are no longer broken as of #415358.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: fishPlugins.pure

3 participants