Skip to content

Comments

boringssl: unstable-2024-09-20 -> 0.20250415.0#393230

Closed
theoparis wants to merge 3 commits intoNixOS:masterfrom
tinted-software:push-vxpssonknyur
Closed

boringssl: unstable-2024-09-20 -> 0.20250415.0#393230
theoparis wants to merge 3 commits intoNixOS:masterfrom
tinted-software:push-vxpssonknyur

Conversation

@theoparis
Copy link
Contributor

@theoparis theoparis commented Mar 25, 2025

I updated boringssl to the latest version, which has now been re-licensed under the Apache 2.0 license. I also added myself as a maintainer. I plan on adding rust support to this package as well as a .pc file for pkg-config.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 25, 2025
@theoparis
Copy link
Contributor Author

theoparis commented Mar 26, 2025

This is still marked as a draft since I've been having trouble figuring out how to use cmake + buildRustPackage in the same derivation to enable the rust bindings to build.
Edit: I guess I can just hold off on that for now.

@theoparis theoparis marked this pull request as ready for review March 26, 2025 01:53
@nix-owners nix-owners bot requested a review from thoughtpolice March 26, 2025 02:01
@antonmosich
Copy link
Contributor

It seems to have been wrong already, but version must start with a digit as per pkgs/README.md. It seems boringssl is now being tagged monthly-ish, is there a reason not to use the tags?

@theoparis
Copy link
Contributor Author

Oh I didn't notice that a digit was required now. I think using the new release tags is a good idea.

@antonmosich
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393230


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • mautrix-signal
❌ 5 packages failed to build:
  • libtensorflow (libtensorflow.python)
  • python312Packages.smolagents
  • python312Packages.smolagents.dist
  • python313Packages.smolagents
  • python313Packages.smolagents.dist
✅ 19 packages built:
  • boringssl
  • boringssl.bin
  • boringssl.dev
  • janus-gateway
  • janus-gateway.dev
  • janus-gateway.doc
  • janus-gateway.man
  • libsignal-ffi
  • open-webui
  • open-webui.dist
  • python312Packages.duckduckgo-search
  • python312Packages.duckduckgo-search.dist
  • python312Packages.primp
  • python312Packages.primp.dist
  • python313Packages.duckduckgo-search
  • python313Packages.duckduckgo-search.dist
  • python313Packages.primp
  • python313Packages.primp.dist
  • ustreamer

@theoparis theoparis changed the title boringssl: unstable-2024-09-20 -> unstable-2025-03-25 boringssl: unstable-2024-09-20 -> 0.20250415.0 Apr 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 17, 2025
@theoparis theoparis force-pushed the push-vxpssonknyur branch 2 times, most recently from 642b771 to bafe81a Compare July 28, 2025 19:50
@theoparis
Copy link
Contributor Author

theoparis commented Jul 28, 2025

This is now blocked by 0x676e67/boring2#90. I tried to update the primp package to remove the unnecessary preBuild script but ran into issues with the patches used by the rquest crate.

Edit: It seems like boring/boring2 is used by a lot of other rust/python/node.js packages, so this isn't a simple fix unfortunately... the boringssl version can't easily be updated in rust dependencies of dependencies of python/js packages.

@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 21, 2025
@theoparis
Copy link
Contributor Author

theoparis commented Sep 29, 2025

This PR is still relevant because my PR uses the cmake install target instead of manually installing the static libraries. I guess I could make a new PR for that

@SuperSandro2000
Copy link
Member

Please rebase if this is still applicable.

@niklaskorz
Copy link
Member

Please rebase if this is still applicable.

My PR was based on this (and attributed through the co-authored-by footer), so this can be closed.

@niklaskorz niklaskorz closed this Nov 6, 2025
@niklaskorz
Copy link
Member

niklaskorz commented Nov 6, 2025

Superseded by #453894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants