Skip to content

Comments

python3Packages.llm-openrouter: add acruru as maintainer#393231

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
arcuru:llm-openrouter-0-4
Jun 20, 2025
Merged

python3Packages.llm-openrouter: add acruru as maintainer#393231
philiptaron merged 1 commit intoNixOS:masterfrom
arcuru:llm-openrouter-0-4

Conversation

@arcuru
Copy link
Contributor

@arcuru arcuru commented Mar 25, 2025

Closes #388943

This is another plugin for the llm software. There are several existing plugins in nixpkgs already: llm-ollama, llm-anthropic, etc.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Testing

Tested this built with nixpkgs-reviewand manually checked that it worked with llm

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 25, 2025
@nix-owners nix-owners bot requested a review from natsukium March 25, 2025 22:46
@arcuru arcuru force-pushed the llm-openrouter-0-4 branch from 2fb68b2 to 50981fa Compare March 25, 2025 22:48
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 27, 2025
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josh
Copy link
Contributor

josh commented Apr 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393231


aarch64-darwin

✅ 4 packages built:
  • python312Packages.llm-openrouter
  • python312Packages.llm-openrouter.dist
  • python313Packages.llm-openrouter
  • python313Packages.llm-openrouter.dist

Copy link
Contributor

@josh josh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Cool to see another llm plugin here.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 9, 2025
@augustebaum
Copy link
Contributor

Thanks for the PR, would love to see this merged!

@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 16, 2025
@arcuru arcuru force-pushed the llm-openrouter-0-4 branch from 50981fa to a0bcc8a Compare May 17, 2025 07:45
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
@arcuru
Copy link
Contributor Author

arcuru commented May 17, 2025

Sorry! Didn't realize this was waiting on me!

Updated to the slightly newer v0.4.1, fixed the feedback, rebased, and fixed the merge conflict.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@arcuru
Copy link
Contributor Author

arcuru commented Jun 20, 2025

The remaining merge conflict is because @philiptaron self-merged their own copy of this in #411459 which is effectively identical.

Closing

@arcuru arcuru closed this Jun 20, 2025
@philiptaron
Copy link
Contributor

Sorry, I didn't see this. I'd be glad to have you as a co-maintainer.

@philiptaron philiptaron reopened this Jun 20, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 20, 2025
Co-authored-by: Philip Taron <philip.taron@gmail.com>
@philiptaron philiptaron changed the title python3Packages.llm-openrouter: init at 0.4 python3Packages.llm-openrouter: add acruru as maintainer Jun 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jun 20, 2025
@github-actions github-actions bot added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. label Jun 20, 2025
@philiptaron philiptaron merged commit 02db783 into NixOS:master Jun 20, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: llm-openrouter

7 participants