python3Packages.llm-openrouter: add acruru as maintainer#393231
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Jun 20, 2025
Merged
python3Packages.llm-openrouter: add acruru as maintainer#393231philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
2fb68b2 to
50981fa
Compare
ethancedwards8
approved these changes
Mar 27, 2025
Contributor
|
josh
approved these changes
Apr 9, 2025
Contributor
josh
left a comment
There was a problem hiding this comment.
Thanks for this! Cool to see another llm plugin here.
Contributor
|
Thanks for the PR, would love to see this merged! |
50981fa to
a0bcc8a
Compare
Contributor
Author
|
Sorry! Didn't realize this was waiting on me! Updated to the slightly newer v0.4.1, fixed the feedback, rebased, and fixed the merge conflict. |
Contributor
Author
|
The remaining merge conflict is because @philiptaron self-merged their own copy of this in #411459 which is effectively identical. Closing |
Contributor
|
Sorry, I didn't see this. I'd be glad to have you as a co-maintainer. |
a0bcc8a to
7bd9a83
Compare
Co-authored-by: Philip Taron <philip.taron@gmail.com>
7bd9a83 to
7fe7b58
Compare
philiptaron
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #388943
This is another plugin for the
llmsoftware. There are several existing plugins in nixpkgs already:llm-ollama,llm-anthropic, etc.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Testing
Tested this built with
nixpkgs-reviewand manually checked that it worked withllmAdd a 👍 reaction to pull requests you find important.