Skip to content

Comments

openroad: fix darwin build#393302

Merged
wegank merged 1 commit intoNixOS:masterfrom
Emin017:openroad-darwin
Mar 28, 2025
Merged

openroad: fix darwin build#393302
wegank merged 1 commit intoNixOS:masterfrom
Emin017:openroad-darwin

Conversation

@Emin017
Copy link
Member

@Emin017 Emin017 commented Mar 26, 2025

  1. Add llvmPackages.openmp to buildInputs on darwin platform
  2. Platform-specific adjustments including Darwin flags and TCL library path fixes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 26, 2025
@nix-owners nix-owners bot requested review from hzeller and trepetti March 26, 2025 05:30
@Emin017
Copy link
Member Author

Emin017 commented Mar 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393302

x86_64-linux

✅ 1 package built:
  • openroad

@Emin017
Copy link
Member Author

Emin017 commented Mar 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393302

aarch64-darwin

✅ 1 package built:
  • openroad

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 26, 2025
wegank
wegank reviewed Mar 28, 2025
View reviewed changes
@Emin017 @wegank
openroad: fix darwin build
d4d6cb6 
1. Add llvmPackages.openmp to buildInputs on darwin platform
2. Platform-specific adjustments including Darwin flags and TCL library
path fixes

Signed-off-by: Qiming Chu <cchuqiming@gmail.com>
@wegank wegank merged commit 54da946 into NixOS:master Mar 28, 2025
23 of 27 checks passed
@Emin017 Emin017 mentioned this pull request Apr 3, 2025
Open
@Emin017 Emin017 deleted the openroad-darwin branch September 8, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@trepetti trepetti Awaiting requested review from trepetti

+1 more reviewer

@hzeller hzeller hzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emin017 @hzeller @wegank