Skip to content

Comments

redlib: 0.35.1-unstable-2024-11-01 -> 0.36.0#393696

Closed
bpeetz wants to merge 2 commits intoNixOS:release-24.11from
bpeetz:redlib-backport
Closed

redlib: 0.35.1-unstable-2024-11-01 -> 0.36.0#393696
bpeetz wants to merge 2 commits intoNixOS:release-24.11from
bpeetz:redlib-backport

Conversation

@bpeetz
Copy link
Contributor

@bpeetz bpeetz commented Mar 27, 2025

This is a backport of all the changes in unstable. The current version does not work due to changes on reddit's side.
references: #391466

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bpeetz bpeetz requested a review from Guanran928 March 27, 2025 11:55
bpeetz added 2 commits March 29, 2025 13:21
This is a backport of all the changes in unstable. The current version
does not work due to changes on reddit's side.
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 29, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393696


x86_64-linux

✅ 1 package built:
  • redlib

aarch64-linux

✅ 1 package built:
  • redlib

aarch64-darwin

✅ 1 package built:
  • redlib

@wolfgangwalther
Copy link
Contributor

Please do the following when manually backporting changes:

  • mention in the PR description which other PR you are backporting (the one you mentioned seems not to be everything)
  • cherry-pick with -x, which will put the commit reference in the new commit message and allow the "check cherry-picks" job to work.

This is also documented: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

@bpeetz
Copy link
Contributor Author

bpeetz commented Apr 7, 2025

The problem with the git cherry-pick -x part is that the difference between release-24.11 and master contains some treewide commits and some updates that were backported without actually backporting all commits leading to the update. Both of these require the usage of something like git checkout <sha> -p -- ./pkgs/by-name/re/redlib/package.nix (because the cherry-pick does not apply at all), which seems to involved for me considering that the 25.05 release is rather close. As such I think it is easier to let this backport be and wait for the 25.05 release.

Regarding the security vulnerability that motivated my attempt in the first place: It is a Denial of Service, which does not really sound like a problem considering that redlib is since circa 5 months in a useless state on stable. As such, the chance that someone still runs redlib from stable is rather slim.

@bpeetz bpeetz closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants