Skip to content

Comments

backport jackett 0.22.1512 to 24.11#393728

Closed
jmmaloney4 wants to merge 1 commit intoNixOS:release-24.11from
jmmaloney4:backport-jackett-24.11
Closed

backport jackett 0.22.1512 to 24.11#393728
jmmaloney4 wants to merge 1 commit intoNixOS:release-24.11from
jmmaloney4:backport-jackett-24.11

Conversation

@jmmaloney4
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 27, 2025
@nix-owners nix-owners bot requested review from edwtjo, nyanloutre and purcell March 27, 2025 13:36
@jmmaloney4 jmmaloney4 force-pushed the backport-jackett-24.11 branch from 8d0416e to d52837a Compare April 5, 2025 04:50
@wolfgangwalther
Copy link
Contributor

Please do the following when manually backporting changes:

  • mention in the PR description which other PR you are backporting
  • cherry-pick with -x, which will put the commit reference in the new commit message and allow the "check cherry-picks" job to work.

This is also documented: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

@wolfgangwalther wolfgangwalther marked this pull request as draft April 26, 2025 16:57
@wolfgangwalther wolfgangwalther added the 4.workflow: backport This targets a stable branch label May 4, 2025
@wolfgangwalther
Copy link
Contributor

With 25.05 released, 24.11 on its way out and no activity here, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants