Skip to content

Comments

ocamlPackages.{apron,mopsa}: migrate to flint3#393959

Merged
wegank merged 2 commits intoNixOS:masterfrom
wegank:ocaml-apron-flint3
Mar 28, 2025
Merged

ocamlPackages.{apron,mopsa}: migrate to flint3#393959
wegank merged 2 commits intoNixOS:masterfrom
wegank:ocaml-apron-flint3

Conversation

@wegank
Copy link
Member

@wegank wegank commented Mar 28, 2025

Should be fine since antoinemine/apron#105 (I'll ask Antoine otherwise).

MOPSA doesn't directly depend on FLINT, though; probably FLINT should be propagated from Apron?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Mar 28, 2025
@nix-owners nix-owners bot requested a review from ulrikstrid March 28, 2025 10:42
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 28, 2025
@nix-owners nix-owners bot requested a review from vbgl March 28, 2025 10:48
@wegank
Copy link
Member Author

wegank commented Mar 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393959


x86_64-linux

✅ 6 packages built:
  • framac
  • ikos
  • jasmin-compiler
  • jasmin-compiler.bin
  • jasmin-compiler.lib
  • mopsa (mopsa.bin)

@wegank wegank merged commit 5c29fd7 into NixOS:master Mar 28, 2025
48 of 51 checks passed
@wegank wegank deleted the ocaml-apron-flint3 branch March 28, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants