Conversation
9aa4c4d to
33fb258
Compare
Member
Author
|
33fb258 to
40a06cf
Compare
40a06cf to
8cdef69
Compare
techknowlogick
approved these changes
Mar 30, 2025
JuliusFreudenberger
approved these changes
Mar 30, 2025
Contributor
JuliusFreudenberger
left a comment
There was a problem hiding this comment.
Based on the commit activity I expect at least one more release for v15, but that can directly be applied for release-24.11 as well.
I think the decision dropping v15 and keeping v16 for 25.05 is right.
tomberek
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teleport 15 is expected to go EOL at around the time of NixOS 25.05 release (see https://goteleport.com/docs/upcoming-releases/).
This removes
teleport_15, as well as all the version conditionals refering to versions 15 or 16 - the conditions were eitherversion >= 15(now always true),version >= 16(now always true), orversion < 16(now always false).Teleport 16 will be supported for most of the lifetime of NixOS 25.05, and Teleport 17, which has been made the default (see #393709), will be supported for the entirety of 25.05's lifetime..
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.