Skip to content

Comments

teleport_15: remove#394056

Merged
tomberek merged 1 commit intoNixOS:masterfrom
justinas:teleport-15-remove
Apr 1, 2025
Merged

teleport_15: remove#394056
tomberek merged 1 commit intoNixOS:masterfrom
justinas:teleport-15-remove

Conversation

@justinas
Copy link
Member

@justinas justinas commented Mar 28, 2025

Teleport 15 is expected to go EOL at around the time of NixOS 25.05 release (see https://goteleport.com/docs/upcoming-releases/).

This removes teleport_15, as well as all the version conditionals refering to versions 15 or 16 - the conditions were either version >= 15 (now always true), version >= 16 (now always true), or version < 16 (now always false).

Teleport 16 will be supported for most of the lifetime of NixOS 25.05, and Teleport 17, which has been made the default (see #393709), will be supported for the entirety of 25.05's lifetime..

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 28, 2025
@justinas justinas force-pushed the teleport-15-remove branch from 9aa4c4d to 33fb258 Compare March 28, 2025 17:33
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 28, 2025
@justinas
Copy link
Member Author

justinas commented Mar 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 394056


x86_64-linux

✅ 4 packages built:
  • teleport (teleport_17)
  • teleport.client (teleport_17.client)
  • teleport_16
  • teleport_16.client

@justinas justinas force-pushed the teleport-15-remove branch from 33fb258 to 40a06cf Compare March 29, 2025 15:06
@justinas justinas force-pushed the teleport-15-remove branch from 40a06cf to 8cdef69 Compare March 30, 2025 16:55
@justinas justinas marked this pull request as ready for review March 30, 2025 18:37
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 30, 2025
Copy link
Contributor

@JuliusFreudenberger JuliusFreudenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the commit activity I expect at least one more release for v15, but that can directly be applied for release-24.11 as well.
I think the decision dropping v15 and keeping v16 for 25.05 is right.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 31, 2025
@tomberek tomberek merged commit ec4abea into NixOS:master Apr 1, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants