Open
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
Author
|
Since I'm using a single file for multiple named variants, I don't see how the |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5336 |
Contributor
|
Just like you do right now, except |
Contributor
There was a problem hiding this comment.
Since this is a configuration parameter rather than a dependency, it would be somewhat idiomatic to give it a default value. This was never a firm rule (at least AFAIK), but it's already an observable pattern
Contributor
There was a problem hiding this comment.
Please use the (finalAttrs: pattern for easier overriding.
13 tasks
mightyiam
changed the title
nixpkgs-ci
bot
added
the
12.first-time contribution
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://codeberg.org/vula/highctidh
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.