Skip to content

Comments

mpd: 0.23.17 -> 0.24.2#394342

Merged
Scrumplex merged 1 commit intoNixOS:masterfrom
misuzu:mpd-update
Mar 29, 2025
Merged

mpd: 0.23.17 -> 0.24.2#394342
Scrumplex merged 1 commit intoNixOS:masterfrom
misuzu:mpd-update

Conversation

@misuzu
Copy link
Contributor

@misuzu misuzu commented Mar 29, 2025

https://github.com/MusicPlayerDaemon/MPD/releases/tag/v0.24.2
Changelog: https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.2/NEWS

Replaced the patch revert with substituteInPlace calls.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@misuzu misuzu requested a review from Scrumplex March 29, 2025 14:51
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 29, 2025
@nix-owners nix-owners bot requested review from astsmtl and tobim March 29, 2025 14:58
@Scrumplex
Copy link
Member

According to the changelog, boost was removed in 0.24.0. I removed it from buildInputs in my testing and it still builds.

* replace the patch revert with substituteInPlace calls
* remove the boost dependency
@misuzu
Copy link
Contributor Author

misuzu commented Mar 29, 2025

According to the changelog, boost was removed in 0.24.0. I removed it from buildInputs in my testing and it still builds.

I've removed it, thanks!

@Scrumplex Scrumplex merged commit 6368a20 into NixOS:master Mar 29, 2025
24 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 29, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants