sh4d0wup: init at 0.11.0 #395433
Merged
sh4d0wup: init at 0.11.0 #395433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 1
0xda157
reviewed
Apr 4, 2025
pkgs/by-name/sh/sh4d0wup/package.nix
Outdated
Contributor
There was a problem hiding this comment.
you could use finalAttrs here, makes it easier to override
Member
Author
There was a problem hiding this comment.
can you give me an example? :) I've done it like this in other packages too.
Contributor
There was a problem hiding this comment.
rustPlatform.buildRustPackage (finalAttrs: {
pname = "sh4d0wup";
version = "0.11.0";
src = fetchFromGitHub {
owner = "kpcyrd";
repo = "sh4d0wup";
tag = "v${finalAttrs.version}";
hash = "sha256-gzkh+JYwuYvdNljB6agEVd7WxqJ5lI3sseY3BlkLmXs=";
};
})
Contributor
|
0xda157
approved these changes
Apr 5, 2025
0xda157
reviewed
Apr 17, 2025
pkgs/by-name/sh/sh4d0wup/package.nix
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| nativeInstallCheck = [ versionCheckHook ]; | |
| nativeInstallCheckInputs = [ versionCheckHook ]; |
Member
Author
There was a problem hiding this comment.
Thanks, I've amended the commit.
0xda157
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.