Skip to content

Conversation

@marcin-serwin
Copy link
Contributor

@marcin-serwin marcin-serwin commented Apr 4, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 4, 2025
@pbsds
Copy link
Member

pbsds commented Apr 19, 2025

It seems to struggle on darwin
https://hydra.nixos.org/job/nixpkgs/trunk/ltris.aarch64-darwin
https://hydra.nixos.org/job/nixpkgs/trunk/ltris.x86_64-darwin

please mark it broken on darwin or reduce the supported platforms

@marcin-serwin
Copy link
Contributor Author

please mark it broken on darwin or reduce the supported platforms

Done

@pbsds
Copy link
Member

pbsds commented Apr 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396087


x86_64-linux

✅ 1 package built:
  • ltris

aarch64-linux

✅ 1 package built:
  • ltris

x86_64-darwin

⏩ 1 package marked as broken and skipped:
  • ltris

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • ltris

@pbsds pbsds merged commit 2b63441 into NixOS:master Apr 20, 2025
31 of 35 checks passed
@marcin-serwin marcin-serwin deleted the push-ynlyqklzlkwy branch May 22, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants