Skip to content

Conversation

@haylinmoore
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 5, 2025
@haylinmoore
Copy link
Contributor Author

       > Running phase: checkPhase
       > ok      github.com/aristanetworks/goarista/areflect     0.218s
       > ok      github.com/aristanetworks/goarista/cmd/json2test        0.195s
       > ok      github.com/aristanetworks/goarista/cmd/ocprometheus     0.314s
       > ok      github.com/aristanetworks/goarista/cmd/octsdb   0.285s
       > ok      github.com/aristanetworks/goarista/cmd/test2influxdb    0.237s
       > panic: runtime error: invalid memory address or nil pointer dereference
       > [signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x10088c714]
       >
       > goroutine 19 [running]:
       > github.com/aristanetworks/goarista/dscp_test.TestDialTCPTimeoutWithTOS.func1.1()
       >         /private/tmp/nix-build-goarista-0-unstable-2025-03-24.drv-0/source/dscp/dial_test.go:82 +0x84
       > created by github.com/aristanetworks/goarista/dscp_test.TestDialTCPTimeoutWithTOS.func1 in goroutine 18
       >         /private/tmp/nix-build-goarista-0-unstable-2025-03-24.drv-0/source/dscp/dial_test.go:77 +0x134
       > FAIL    github.com/aristanetworks/goarista/dscp 0.242s
       > FAIL
       For full logs, run 'nix log /nix/store/gn9s23d7zdq9xf7hdcp8zgcd70500b87-goarista-0-unstable-2025-03-24.drv'.
error: 1 dependencies of derivation '/nix/store/mfw71i8n425h3872m8bix08m2g2jv461-review-shell.drv' failed to build

The aforementioned Darwin test failure

@haylinmoore
Copy link
Contributor Author

The binaries when tested still work on Darwin, so I am going to just disable the test on Darwin

@haylinmoore
Copy link
Contributor Author

haylinmoore commented Apr 5, 2025

Have you tried __darwinAllowLocalNetworking = true;

I was not aware of that option, but upon trying with that it still errors.

@haylinmoore
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396427


aarch64-darwin

✅ 1 package built:
  • goarista

@haylinmoore
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396427


x86_64-linux

✅ 1 package built:
  • goarista

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 6, 2025
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 7, 2025
@wegank
Copy link
Member

wegank commented Apr 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396427


aarch64-darwin

✅ 1 package built:
  • goarista

@wegank wegank merged commit 246969a into NixOS:master Apr 23, 2025
29 checks passed
@haylinmoore haylinmoore deleted the goarista-init branch April 25, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants